mirror of
https://github.com/projectacrn/acrn-hypervisor.git
synced 2025-12-10 14:44:45 +00:00
3027bfab10
In the hypervisor, physical cpu id is defined as "int" or "uint32_t"
type in the hypervisor. So there are some sign conversion issues
about physical cpu id (pcpu_id) reported by static analysis tool.
Sign conversion violates the rules of MISRA C:2012.
In this patch, define physical cpu id as "uint16_t" type for all
modules in the hypervisor and change related codes. The valid
range of pcpu_id is 0~65534, INVALID_PCPU_ID is defined to the
invalid pcpu_id for error detection, BROADCAST_PCPU_ID is
broadcast pcpu_id used to notify all valid pcpu.
The type of pcpu_id in the struct vcpu and vcpu_id is "int" type,
this will be fixed in another patch.
V1-->V2:
* Change the type of pcpu_id from uint32_t to uint16_t;
* Define INVALID_PCPU_ID for error detection;
* Define BROADCAST_PCPU_ID to notify all valid pcpu.
V2-->V3:
* Update comments for INVALID_PCPU_ID and BROADCAST_PCPU_ID;
* Update addtional pcpu_id;
* Convert hexadecimals to unsigned to meet the type of pcpu_id;
* Clean up for MIN_PCPU_ID and MAX_PCPU_ID, they will be
defined by configuration.
Note: fix bug in the init_lapic(), the pcpu_id shall be less than 8,
this is constraint by implement in the init_lapic().
Signed-off-by: Xiangyang Wu <xiangyang.wu@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
35 lines
955 B
C
35 lines
955 B
C
/*
|
|
* Copyright (C) 2018 Intel Corporation. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#ifndef ACPI_H
|
|
#define ACPI_H
|
|
|
|
struct acpi_table_header {
|
|
/* ASCII table signature */
|
|
char signature[4];
|
|
/* Length of table in bytes, including this header */
|
|
uint32_t length;
|
|
/* ACPI Specification minor version number */
|
|
uint8_t revision;
|
|
/* To make sum of entire table == 0 */
|
|
uint8_t checksum;
|
|
/* ASCII OEM identification */
|
|
char oem_id[6];
|
|
/* ASCII OEM table identification */
|
|
char oem_table_id[8];
|
|
/* OEM revision number */
|
|
uint32_t oem_revision;
|
|
/* ASCII ASL compiler vendor ID */
|
|
char asl_compiler_id[4];
|
|
/* ASL compiler version */
|
|
uint32_t asl_compiler_revision;
|
|
};
|
|
|
|
uint16_t parse_madt(uint8_t *lapic_id_base);
|
|
|
|
void *get_dmar_table(void);
|
|
#endif /* !ACPI_H */
|