mirror of
https://github.com/projectacrn/acrn-hypervisor.git
synced 2025-05-04 06:26:54 +00:00
3027bfab10
In the hypervisor, physical cpu id is defined as "int" or "uint32_t"
type in the hypervisor. So there are some sign conversion issues
about physical cpu id (pcpu_id) reported by static analysis tool.
Sign conversion violates the rules of MISRA C:2012.
In this patch, define physical cpu id as "uint16_t" type for all
modules in the hypervisor and change related codes. The valid
range of pcpu_id is 0~65534, INVALID_PCPU_ID is defined to the
invalid pcpu_id for error detection, BROADCAST_PCPU_ID is
broadcast pcpu_id used to notify all valid pcpu.
The type of pcpu_id in the struct vcpu and vcpu_id is "int" type,
this will be fixed in another patch.
V1-->V2:
* Change the type of pcpu_id from uint32_t to uint16_t;
* Define INVALID_PCPU_ID for error detection;
* Define BROADCAST_PCPU_ID to notify all valid pcpu.
V2-->V3:
* Update comments for INVALID_PCPU_ID and BROADCAST_PCPU_ID;
* Update addtional pcpu_id;
* Convert hexadecimals to unsigned to meet the type of pcpu_id;
* Clean up for MIN_PCPU_ID and MAX_PCPU_ID, they will be
defined by configuration.
Note: fix bug in the init_lapic(), the pcpu_id shall be less than 8,
this is constraint by implement in the init_lapic().
Signed-off-by: Xiangyang Wu <xiangyang.wu@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
70 lines
1.6 KiB
C
70 lines
1.6 KiB
C
/*
|
|
* Copyright (C) 2018 Intel Corporation. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <hypervisor.h>
|
|
|
|
static struct dev_handler_node *notification_node;
|
|
|
|
/* run in interrupt context */
|
|
static int kick_notification(__unused int irq, __unused void *data)
|
|
{
|
|
/* Notification vector does not require handling here, it's just used
|
|
* to kick taget cpu out of non-root mode.
|
|
*/
|
|
return 0;
|
|
}
|
|
|
|
static int request_notification_irq(dev_handler_t func, void *data,
|
|
const char *name)
|
|
{
|
|
uint32_t irq = IRQ_INVALID; /* system allocate */
|
|
struct dev_handler_node *node = NULL;
|
|
|
|
if (notification_node != NULL) {
|
|
pr_info("%s, Notification vector already allocated on this CPU",
|
|
__func__);
|
|
return -EBUSY;
|
|
}
|
|
|
|
/* all cpu register the same notification vector */
|
|
node = pri_register_handler(irq, VECTOR_NOTIFY_VCPU, func, data, name);
|
|
if (node == NULL) {
|
|
pr_err("Failed to add notify isr");
|
|
return -1;
|
|
}
|
|
update_irq_handler(dev_to_irq(node), quick_handler_nolock);
|
|
notification_node = node;
|
|
return 0;
|
|
}
|
|
|
|
void setup_notification(void)
|
|
{
|
|
uint16_t cpu;
|
|
char name[32] = {0};
|
|
|
|
cpu = get_cpu_id();
|
|
if (cpu > 0)
|
|
return;
|
|
|
|
/* support IPI notification, VM0 will register all CPU */
|
|
snprintf(name, 32, "NOTIFY_ISR%d", cpu);
|
|
if (request_notification_irq(kick_notification, NULL, name) < 0) {
|
|
pr_err("Failed to setup notification");
|
|
return;
|
|
}
|
|
|
|
dev_dbg(ACRN_DBG_PTIRQ, "NOTIFY: irq[%d] setup vector %x",
|
|
dev_to_irq(notification_node),
|
|
dev_to_vector(notification_node));
|
|
}
|
|
|
|
void cleanup_notification(void)
|
|
{
|
|
if (notification_node != NULL)
|
|
unregister_handler_common(notification_node);
|
|
notification_node = NULL;
|
|
}
|