mirror of
https://github.com/kubernetes/client-go.git
synced 2025-09-03 08:04:45 +00:00
cache: Reflector should have the same injected clock as its informer
While refactoring the backoff manager to simplify and unify the code in wait a race condition was encountered in TestSharedInformerWatchDisruption. The new implementation failed because the fake clock was not propagated to the backoff managers when the reflector was used in a controller. After ensuring the mangaers, reflector, controller, and informer shared the same clock the test needed was updated to avoid the race condition by advancing the fake clock and adding real sleeps to wait for asynchronous propagation of the various goroutines in the controller. Due to the deep structure of informers it is difficult to inject hooks to avoid having to perform sleeps. At a minimum the FakeClock interface should allow a caller to determine the number of waiting timers (to avoid the first sleep). Kubernetes-commit: 91b3a81fbd916713afe215f7d701950e13a02869
This commit is contained in:
committed by
Kubernetes Publisher
parent
241dfe3630
commit
08e22c4b64
12
tools/cache/shared_informer_test.go
vendored
12
tools/cache/shared_informer_test.go
vendored
@@ -348,6 +348,18 @@ func TestSharedInformerWatchDisruption(t *testing.T) {
|
||||
// Simulate a connection loss (or even just a too-old-watch)
|
||||
source.ResetWatch()
|
||||
|
||||
// Wait long enough for the reflector to exit and the backoff function to start waiting
|
||||
// on the fake clock, otherwise advancing the fake clock will have no effect.
|
||||
// TODO: Make this deterministic by counting the number of waiters on FakeClock
|
||||
time.Sleep(10 * time.Millisecond)
|
||||
|
||||
// Advance the clock to cause the backoff wait to expire.
|
||||
clock.Step(1601 * time.Millisecond)
|
||||
|
||||
// Wait long enough for backoff to invoke ListWatch a second time and distribute events
|
||||
// to listeners.
|
||||
time.Sleep(10 * time.Millisecond)
|
||||
|
||||
for _, listener := range listeners {
|
||||
if !listener.ok() {
|
||||
t.Errorf("%s: expected %v, got %v", listener.name, listener.expectedItemNames, listener.receivedItemNames)
|
||||
|
Reference in New Issue
Block a user