Switch WaitForCertificate to informers to avoid broken watches

Kubernetes-commit: a7588723f7e9b88c2e8b9d601a2391e0f6b19a17
This commit is contained in:
Tomas Nozicka
2019-01-17 18:32:36 +01:00
committed by Kubernetes Publisher
parent 5846423975
commit 0dbe75c417
3 changed files with 26 additions and 49 deletions

View File

@@ -31,7 +31,6 @@ import (
"k8s.io/apimachinery/pkg/api/errors"
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/util/wait"
watch "k8s.io/apimachinery/pkg/watch"
certificatesclient "k8s.io/client-go/kubernetes/typed/certificates/v1beta1"
)
@@ -433,7 +432,8 @@ func TestRotateCertWaitingForResultError(t *testing.T) {
},
}
certificateWaitBackoff = wait.Backoff{Steps: 1}
defer func(t time.Duration) { certificateWaitTimeout = t }(certificateWaitTimeout)
certificateWaitTimeout = 1 * time.Millisecond
if success, err := m.rotateCerts(); success {
t.Errorf("Got success from 'rotateCerts', wanted failure.")
} else if err != nil {
@@ -880,15 +880,6 @@ func TestServerHealth(t *testing.T) {
expectRotateFail: true,
expectHealthy: true,
},
{
description: "Conflict error on watch",
certs: currentCerts,
failureType: watchError,
clientErr: errors.NewGenericServerResponse(409, "POST", schema.GroupResource{}, "", "", 0, false),
expectRotateFail: true,
expectHealthy: false,
},
}
for _, tc := range testCases {