github/client-go
1
0
Fork 0
mirror of https://github.com/kubernetes/client-go.git synced 2025-06-28 07:57:20 +00:00
Code Issues Projects Releases Wiki Activity

Implement dynamic admission webhooks

Browse Source 
Also fix a bug in rest client

Kubernetes-commit: d6e1140b5d3c5c9d8696b7ccda0a5f92f36033df
This commit is contained in:
Daniel Smith 2017-05-24 15:31:34 -07:00 committed by Kubernetes Publisher
parent d9ea62815a
commit 38cb1a951d
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
rest/request.go
View File

@ -1148,6 +1148,9 @@ func (r Result) Into(obj runtime.Object) error {
if r.decoder == nil { if r.decoder == nil {
return fmt.Errorf("serializer for %s doesn't exist", r.contentType) return fmt.Errorf("serializer for %s doesn't exist", r.contentType)
} }
if len(r.body) == 0 {
return fmt.Errorf("0-length response")
}
out, _, err := r.decoder.Decode(r.body, nil, obj) out, _, err := r.decoder.Decode(r.body, nil, obj)
if err != nil || out == obj { if err != nil || out == obj {

10
rest/request_test.go
View File

@ -329,6 +329,16 @@ func TestResultIntoWithErrReturnsErr(t *testing.T) {
} }
} }
func TestResultIntoWithNoBodyReturnsErr(t *testing.T) {
res := Result{
body: []byte{},
decoder: scheme.Codecs.LegacyCodec(v1.SchemeGroupVersion),
}
if err := res.Into(&v1.Pod{}); err == nil || !strings.Contains(err.Error(), "0-length") {
t.Errorf("should have complained about 0 length body")
}
}
func TestURLTemplate(t *testing.T) { func TestURLTemplate(t *testing.T) {
uri, _ := url.Parse("http://localhost") uri, _ := url.Parse("http://localhost")
r := NewRequest(nil, "POST", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil) r := NewRequest(nil, "POST", uri, "", ContentConfig{GroupVersion: &schema.GroupVersion{Group: "test"}}, Serializers{}, nil, nil)