From 3da398aea9889860b811d7e7bee827cb36897710 Mon Sep 17 00:00:00 2001 From: Dave Protasowski Date: Tue, 27 Oct 2020 22:45:33 -0400 Subject: [PATCH] Re-add the event recorder in the release test Prior having a mock recorder would cause panics since the lock would be set to nil on update failures. Now the recorder will use the cached lock Kubernetes-commit: 5e7ed7b86d26b651f1ef78a794cdc03fa945a3ce --- tools/leaderelection/leaderelection_test.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/leaderelection/leaderelection_test.go b/tools/leaderelection/leaderelection_test.go index a110abce..24095e7d 100644 --- a/tools/leaderelection/leaderelection_test.go +++ b/tools/leaderelection/leaderelection_test.go @@ -1097,9 +1097,8 @@ func testReleaseOnCancellation(t *testing.T, objectType string) { ) resourceLockConfig := rl.ResourceLockConfig{ - Identity: "baz", - // TODO - uncomment this to introduce errors - // EventRecorder: &record.FakeRecorder{}, + Identity: "baz", + EventRecorder: &record.FakeRecorder{}, } c := &fake.Clientset{}