From 42503cca34e638e9259414a71bc09cc93926bd2c Mon Sep 17 00:00:00 2001 From: Lukasz Szaszkiewicz Date: Tue, 21 Oct 2025 16:25:07 +0200 Subject: [PATCH] client-go/clients: improve TestWatchListSemanticsSimple Kubernetes-commit: 6b82a823b1a91e727d510b2eeab8765f942ad449 --- dynamic/dynamicinformer/informer_test.go | 7 +++++++ metadata/metadatainformer/informer_test.go | 7 +++++++ 2 files changed, 14 insertions(+) diff --git a/dynamic/dynamicinformer/informer_test.go b/dynamic/dynamicinformer/informer_test.go index 02a3c999a..6c779f890 100644 --- a/dynamic/dynamicinformer/informer_test.go +++ b/dynamic/dynamicinformer/informer_test.go @@ -18,6 +18,7 @@ package dynamicinformer_test import ( "context" + "fmt" "testing" "time" @@ -68,6 +69,12 @@ func TestWatchListSemanticsSimple(t *testing.T) { clientfeaturestesting.SetFeatureDuringTest(t, clientfeatures.WatchListClient, true) server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { + if _, ok := req.URL.Query()["watch"]; !ok { + t.Errorf("expected a watch request, params: %v", req.URL.Query()) + http.Error(w, fmt.Errorf("unexpected request").Error(), http.StatusInternalServerError) + return + } + obj := &appsv1.Deployment{ TypeMeta: metav1.TypeMeta{ APIVersion: "apps/v1", diff --git a/metadata/metadatainformer/informer_test.go b/metadata/metadatainformer/informer_test.go index a1b9a99a6..baef474fb 100644 --- a/metadata/metadatainformer/informer_test.go +++ b/metadata/metadatainformer/informer_test.go @@ -19,6 +19,7 @@ package metadatainformer import ( "context" "flag" + "fmt" "net/http" "net/http/httptest" "testing" @@ -52,6 +53,12 @@ func TestWatchListSemanticsSimple(t *testing.T) { clientfeaturestesting.SetFeatureDuringTest(t, clientfeatures.WatchListClient, true) server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { + if _, ok := req.URL.Query()["watch"]; !ok { + t.Errorf("expected a watch request, params: %v", req.URL.Query()) + http.Error(w, fmt.Errorf("unexpected request").Error(), http.StatusInternalServerError) + return + } + obj := &metav1.PartialObjectMetadata{ TypeMeta: metav1.TypeMeta{ APIVersion: "meta.k8s.io/v1",