diff --git a/tools/cache/reflector.go b/tools/cache/reflector.go index a1746285..84f24211 100644 --- a/tools/cache/reflector.go +++ b/tools/cache/reflector.go @@ -231,7 +231,7 @@ var ( // Used to indicate that watching stopped because of a signal from the stop // channel passed in from a client of the reflector. - errorStopRequested = errors.New("Stop requested") + errorStopRequested = errors.New("stop requested") ) // resyncChan returns a channel which will receive something when a resync is @@ -258,7 +258,7 @@ func (r *Reflector) ListAndWatch(stopCh <-chan struct{}) error { options := metav1.ListOptions{ResourceVersion: r.relistResourceVersion()} if err := func() error { - initTrace := trace.New("Reflector ListAndWatch", trace.Field{"name", r.name}) + initTrace := trace.New("Reflector ListAndWatch", trace.Field{Key: "name", Value: r.name}) defer initTrace.LogIfLong(10 * time.Second) var list runtime.Object var paginatedResult bool @@ -319,7 +319,7 @@ func (r *Reflector) ListAndWatch(stopCh <-chan struct{}) error { panic(r) case <-listCh: } - initTrace.Step("Objects listed", trace.Field{"error", err}) + initTrace.Step("Objects listed", trace.Field{Key: "error", Value: err}) if err != nil { klog.Warningf("%s: failed to list %v: %v", r.name, r.expectedTypeName, err) return fmt.Errorf("failed to list %v: %v", r.expectedTypeName, err) diff --git a/tools/cache/reflector_test.go b/tools/cache/reflector_test.go index 49f76bf0..9f35b682 100644 --- a/tools/cache/reflector_test.go +++ b/tools/cache/reflector_test.go @@ -813,7 +813,6 @@ func TestReflectorFullListIfExpired(t *testing.T) { t.Error(err) return nil, err } - return nil, nil }, } r := NewReflector(lw, &v1.Pod{}, s, 0)