From 73c17354d4157ea84fe83dd8dfc03b7e24b680f8 Mon Sep 17 00:00:00 2001 From: Wei Wei Date: Wed, 1 Nov 2017 16:34:18 +0800 Subject: [PATCH] rename metric reflector_xx_last_resource_version to reflector_last_resource_version{name="xx"} Kubernetes-commit: bca495e2291b0a888d5aaee10e901ddb28e937b2 --- tools/cache/reflector.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/cache/reflector.go b/tools/cache/reflector.go index 4967f98d..b4865a64 100644 --- a/tools/cache/reflector.go +++ b/tools/cache/reflector.go @@ -109,7 +109,7 @@ func NewNamedReflector(name string, lw ListerWatcher, expectedType interface{}, r := &Reflector{ name: name, // we need this to be unique per process (some names are still the same)but obvious who it belongs to - metrics: newReflectorMetrics(makeValidPromethusMetricName(fmt.Sprintf("reflector_"+name+"_%d", reflectorSuffix))), + metrics: newReflectorMetrics(makeValidPromethusMetricLabel(fmt.Sprintf("reflector_"+name+"_%d", reflectorSuffix))), listerWatcher: lw, store: store, expectedType: reflect.TypeOf(expectedType), @@ -120,9 +120,9 @@ func NewNamedReflector(name string, lw ListerWatcher, expectedType interface{}, return r } -func makeValidPromethusMetricName(in string) string { +func makeValidPromethusMetricLabel(in string) string { // this isn't perfect, but it removes our common characters - return strings.NewReplacer("/", "_", ".", "_", "-", "_").Replace(in) + return strings.NewReplacer("/", "_", ".", "_", "-", "_", ":", "_").Replace(in) } // internalPackages are packages that ignored when creating a default reflector name. These packages are in the common