github/client-go
1
0
Fork 0
mirror of https://github.com/kubernetes/client-go.git synced 2025-06-24 14:12:18 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #61790 from deads2k/cli-21-scaler

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 61790, 61808, 60339, 61615, 61757). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

make reapers tolerate 404s on scaling down

fixes https://github.com/kubernetes/kubernetes/issues/61748

This fixes the scale client to return the actual API error, not a wrapped one.  It also updates scalers to do the same.  Then it fixes the reapers to tolerate 404s, since that means they achieved their objective.

/assign @janetkuo
/assign @p0lyn0mial

```release-note
NONE
```

Kubernetes-commit: dea3c0a610ebe55ba94e1b7841644b8a0930e770
This commit is contained in:
Kubernetes Publisher 2018-03-28 09:39:08 -07:00
commit 88e8ea169a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
scale/client.go
View File

@ -138,7 +138,7 @@ func (c *namespacedScaleClient) Get(resource schema.GroupResource, name string)
SubResource("scale"). SubResource("scale").
Do() Do()
if err := result.Error(); err != nil { if err := result.Error(); err != nil {
return nil, fmt.Errorf("could not fetch the scale for %s %s: %v", resource.String(), name, err) return nil, err
} }
scaleBytes, err := result.Raw() scaleBytes, err := result.Raw()