github/client-go
1
0
Fork 0
mirror of https://github.com/kubernetes/client-go.git synced 2025-09-13 22:01:43 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #61894 from atlassian/misc-cleanups

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 61894, 61369). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use range in loops; misc fixes

**What this PR does / why we need it**:
It is cleaner to use `range` in for loops to iterate over channel until it is closed.

**Release note**:
```release-note
NONE
```
/kind cleanup

Kubernetes-commit: 7ce753aa73a42d8a8696659e345e173d15cce622
This commit is contained in:
Kubernetes Publisher
2018-03-30 21:16:01 -07:00
parent 991626bd9b 37d44da37d
commit 8c732d02e9
2 changed files with 581 additions and 585 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1160
Godeps/Godeps.json generated
View File

File diff suppressed because it is too large Load Diff

6
tools/record/event.go
View File

@@ -225,11 +225,7 @@ func (eventBroadcaster *eventBroadcasterImpl) StartEventWatcher(eventHandler fun
watcher := eventBroadcaster.Watch() watcher := eventBroadcaster.Watch()
go func() { go func() {
defer utilruntime.HandleCrash() defer utilruntime.HandleCrash()
for { for watchEvent := range watcher.ResultChan() {
watchEvent, open := <-watcher.ResultChan()
if !open {
return
}
event, ok := watchEvent.Object.(*v1.Event) event, ok := watchEvent.Object.(*v1.Event)
if !ok { if !ok {
// This is all local, so there's no reason this should // This is all local, so there's no reason this should