From bac0f5a6c75b733d6642c03e470a4087c7ef72a8 Mon Sep 17 00:00:00 2001 From: wojtekt Date: Thu, 22 Aug 2019 08:58:45 +0200 Subject: [PATCH] Remove dead code Kubernetes-commit: b1675717168826c3314bf5b7e28c282f9643eadf --- deprecated-dynamic/bad_debt.go | 73 ------------------------------- deprecated-dynamic/client_test.go | 3 +- 2 files changed, 2 insertions(+), 74 deletions(-) delete mode 100644 deprecated-dynamic/bad_debt.go diff --git a/deprecated-dynamic/bad_debt.go b/deprecated-dynamic/bad_debt.go deleted file mode 100644 index 7478b49b..00000000 --- a/deprecated-dynamic/bad_debt.go +++ /dev/null @@ -1,73 +0,0 @@ -/* -Copyright 2018 The Kubernetes Authors. - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. -*/ - -package deprecated_dynamic - -import ( - "encoding/json" - "io" - "strings" - - metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" - "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" - "k8s.io/apimachinery/pkg/runtime" - "k8s.io/apimachinery/pkg/runtime/schema" - "k8s.io/apimachinery/pkg/runtime/serializer" - "k8s.io/client-go/kubernetes/scheme" - "k8s.io/client-go/rest" -) - -// dynamicCodec is a codec that wraps the standard unstructured codec -// with special handling for Status objects. -// Deprecated only used by test code and its wrong -type dynamicCodec struct{} - -func (dynamicCodec) Decode(data []byte, gvk *schema.GroupVersionKind, obj runtime.Object) (runtime.Object, *schema.GroupVersionKind, error) { - obj, gvk, err := unstructured.UnstructuredJSONScheme.Decode(data, gvk, obj) - if err != nil { - return nil, nil, err - } - - if _, ok := obj.(*metav1.Status); !ok && strings.ToLower(gvk.Kind) == "status" { - obj = &metav1.Status{} - err := json.Unmarshal(data, obj) - if err != nil { - return nil, nil, err - } - } - - return obj, gvk, nil -} - -func (dynamicCodec) Encode(obj runtime.Object, w io.Writer) error { - return unstructured.UnstructuredJSONScheme.Encode(obj, w) -} - -// ContentConfig returns a rest.ContentConfig for dynamic types. -// Deprecated only used by test code and its wrong -func ContentConfig() rest.ContentConfig { - // TODO: scheme.Codecs here should become "pkg/apis/server/scheme" which is the minimal core you need - // to talk to a kubernetes server - jsonInfo, _ := runtime.SerializerInfoForMediaType(scheme.Codecs.SupportedMediaTypes(), runtime.ContentTypeJSON) - - jsonInfo.Serializer = dynamicCodec{} - jsonInfo.PrettySerializer = nil - return rest.ContentConfig{ - AcceptContentTypes: runtime.ContentTypeJSON, - ContentType: runtime.ContentTypeJSON, - NegotiatedSerializer: serializer.NegotiatedSerializerWrapper(jsonInfo), - } -} diff --git a/deprecated-dynamic/client_test.go b/deprecated-dynamic/client_test.go index 79047452..de88edb5 100644 --- a/deprecated-dynamic/client_test.go +++ b/deprecated-dynamic/client_test.go @@ -511,7 +511,8 @@ func TestWatch(t *testing.T) { t.Errorf("Watch(%q) got query %s. wanted %s", tc.name, r.URL.RawQuery, tc.query) } - enc := restclientwatch.NewEncoder(streaming.NewEncoder(w, dynamicCodec{}), dynamicCodec{}) + codec := unstructured.UnstructuredJSONScheme + enc := restclientwatch.NewEncoder(streaming.NewEncoder(w, codec), codec) for _, e := range tc.events { enc.Encode(&e) }