mirror of
https://github.com/kubernetes/client-go.git
synced 2025-09-25 22:48:22 +00:00
fix: enable empty and len rules from testifylint on pkg package
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com> Co-authored-by: Patrick Ohly <patrick.ohly@intel.com> Kubernetes-commit: f014b754fb5925dfbca6e27a44d0c3968b157e14
This commit is contained in:
committed by
Kubernetes Publisher
parent
7f36d816ee
commit
acc5917341
@@ -152,7 +152,7 @@ func TestOpenAPIDiskCache(t *testing.T) {
|
||||
require.NoError(t, err)
|
||||
defer fakeServer.HttpServer.Close()
|
||||
|
||||
require.Greater(t, len(fakeServer.ServedDocuments), 0)
|
||||
require.NotEmpty(t, fakeServer.ServedDocuments)
|
||||
|
||||
client, err := NewCachedDiscoveryClientForConfig(
|
||||
&restclient.Config{Host: fakeServer.HttpServer.URL},
|
||||
@@ -175,7 +175,7 @@ func TestOpenAPIDiskCache(t *testing.T) {
|
||||
paths, err := openapiClient.Paths()
|
||||
require.NoError(t, err)
|
||||
assert.Equal(t, 1, fakeServer.RequestCounters["/openapi/v3"])
|
||||
require.Greater(t, len(paths), 0)
|
||||
require.NotEmpty(t, paths)
|
||||
|
||||
contentTypes := []string{
|
||||
runtime.ContentTypeJSON, openapi.ContentTypeOpenAPIV3PB,
|
||||
|
@@ -411,7 +411,7 @@ func TestOpenAPIMemCache(t *testing.T) {
|
||||
require.NoError(t, err)
|
||||
defer fakeServer.HttpServer.Close()
|
||||
|
||||
require.Greater(t, len(fakeServer.ServedDocuments), 0)
|
||||
require.NotEmpty(t, fakeServer.ServedDocuments)
|
||||
|
||||
client := NewMemCacheClient(
|
||||
discovery.NewDiscoveryClientForConfigOrDie(
|
||||
@@ -604,7 +604,7 @@ func TestMemCacheGroupsAndMaybeResources(t *testing.T) {
|
||||
require.NoError(t, err)
|
||||
// "Unaggregated" discovery always returns nil for resources.
|
||||
assert.Nil(t, resourcesMap)
|
||||
assert.True(t, len(failedGVs) == 0, "expected empty failed GroupVersions, got (%d)", len(failedGVs))
|
||||
assert.Emptyf(t, failedGVs, "expected empty failed GroupVersions, got (%d)", len(failedGVs))
|
||||
assert.False(t, memClient.receivedAggregatedDiscovery)
|
||||
assert.True(t, memClient.Fresh())
|
||||
// Test the expected groups are returned for the aggregated format.
|
||||
|
Reference in New Issue
Block a user