github/client-go
1
0
Fork 0
mirror of https://github.com/kubernetes/client-go.git synced 2025-08-13 21:15:27 +00:00
Code Issues Projects Releases Wiki Activity

fix: enable empty and len rules from testifylint on pkg package

Browse Source 
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>

Co-authored-by: Patrick Ohly <patrick.ohly@intel.com>

Kubernetes-commit: f014b754fb5925dfbca6e27a44d0c3968b157e14
This commit is contained in:
Matthieu MOREL 2024-06-28 21:20:13 +02:00 committed by Kubernetes Publisher
parent 7f36d816ee
commit acc5917341
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
discovery/cached/disk/cached_discovery_test.go
View File

@ -152,7 +152,7 @@ func TestOpenAPIDiskCache(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
defer fakeServer.HttpServer.Close() defer fakeServer.HttpServer.Close()
require.Greater(t, len(fakeServer.ServedDocuments), 0) require.NotEmpty(t, fakeServer.ServedDocuments)
client, err := NewCachedDiscoveryClientForConfig( client, err := NewCachedDiscoveryClientForConfig(
&restclient.Config{Host: fakeServer.HttpServer.URL}, &restclient.Config{Host: fakeServer.HttpServer.URL},
@ -175,7 +175,7 @@ func TestOpenAPIDiskCache(t *testing.T) {
paths, err := openapiClient.Paths() paths, err := openapiClient.Paths()
require.NoError(t, err) require.NoError(t, err)
assert.Equal(t, 1, fakeServer.RequestCounters["/openapi/v3"]) assert.Equal(t, 1, fakeServer.RequestCounters["/openapi/v3"])
require.Greater(t, len(paths), 0) require.NotEmpty(t, paths)
contentTypes := []string{ contentTypes := []string{
runtime.ContentTypeJSON, openapi.ContentTypeOpenAPIV3PB, runtime.ContentTypeJSON, openapi.ContentTypeOpenAPIV3PB,

4
discovery/cached/memory/memcache_test.go
View File

@ -411,7 +411,7 @@ func TestOpenAPIMemCache(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
defer fakeServer.HttpServer.Close() defer fakeServer.HttpServer.Close()
require.Greater(t, len(fakeServer.ServedDocuments), 0) require.NotEmpty(t, fakeServer.ServedDocuments)
client := NewMemCacheClient( client := NewMemCacheClient(
discovery.NewDiscoveryClientForConfigOrDie( discovery.NewDiscoveryClientForConfigOrDie(
@ -604,7 +604,7 @@ func TestMemCacheGroupsAndMaybeResources(t *testing.T) {
require.NoError(t, err) require.NoError(t, err)
// "Unaggregated" discovery always returns nil for resources. // "Unaggregated" discovery always returns nil for resources.
assert.Nil(t, resourcesMap) assert.Nil(t, resourcesMap)
assert.True(t, len(failedGVs) == 0, "expected empty failed GroupVersions, got (%d)", len(failedGVs)) assert.Emptyf(t, failedGVs, "expected empty failed GroupVersions, got (%d)", len(failedGVs))
assert.False(t, memClient.receivedAggregatedDiscovery) assert.False(t, memClient.receivedAggregatedDiscovery)
assert.True(t, memClient.Fresh()) assert.True(t, memClient.Fresh())
// Test the expected groups are returned for the aggregated format. // Test the expected groups are returned for the aggregated format.

2
tools/cache/reflector_test.go vendored
View File

@ -194,7 +194,7 @@ func TestReflectorWatchStoppedAfter(t *testing.T) {
err := target.watch(nil, stopCh, nil) err := target.watch(nil, stopCh, nil)
require.NoError(t, err) require.NoError(t, err)
require.Equal(t, 1, len(watchers)) require.Len(t, watchers, 1)
require.True(t, watchers[0].IsStopped()) require.True(t, watchers[0].IsStopped())
} }

2
util/consistencydetector/list_data_consistency_detector_test.go
View File

@ -132,7 +132,7 @@ func TestCheckListFromCacheDataConsistencyIfRequestedInternalHappyPath(t *testin
checkListFromCacheDataConsistencyIfRequestedInternal(ctx, "", fakeLister.List, listOptions, scenario.retrievedList) checkListFromCacheDataConsistencyIfRequestedInternal(ctx, "", fakeLister.List, listOptions, scenario.retrievedList)
require.Equal(t, 1, fakeLister.counter) require.Equal(t, 1, fakeLister.counter)
require.Equal(t, 1, len(fakeLister.requestOptions)) require.Len(t, fakeLister.requestOptions, 1)
require.Equal(t, fakeLister.requestOptions[0], scenario.expectedRequestOptions) require.Equal(t, fakeLister.requestOptions[0], scenario.expectedRequestOptions)
}) })
} }