From ed7d154cc2b1cf7f835259a6f17588e81fe34d8d Mon Sep 17 00:00:00 2001 From: Alper Rifat Ulucinar Date: Wed, 30 Mar 2022 11:19:41 +0300 Subject: [PATCH 1/2] Bump default burst limit for discovery client to 300 Signed-off-by: Alper Rifat Ulucinar Kubernetes-commit: 534427f5d3134189f49e6811a7642b86cf92c55a --- discovery/discovery_client.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/discovery/discovery_client.go b/discovery/discovery_client.go index baf87884..a123aa73 100644 --- a/discovery/discovery_client.go +++ b/discovery/discovery_client.go @@ -52,6 +52,9 @@ const ( // defaultTimeout is the maximum amount of time per request when no timeout has been set on a RESTClient. // Defaults to 32s in order to have a distinguishable length of time, relative to other timeouts that exist. defaultTimeout = 32 * time.Second + + // defaultBurst is the default burst to be used with the discovery client's token bucket rate limiter + defaultBurst = 300 ) // DiscoveryInterface holds the methods that discover server-supported API groups, @@ -456,12 +459,14 @@ func setDiscoveryDefaults(config *restclient.Config) error { if config.Timeout == 0 { config.Timeout = defaultTimeout } - if config.Burst == 0 && config.QPS < 100 { + // if a burst limit is not already configured and + // an avg. rate of `defaultBurst` qps is not already configured + if config.Burst == 0 && config.QPS < defaultBurst { // discovery is expected to be bursty, increase the default burst // to accommodate looking up resource info for many API groups. // matches burst set by ConfigFlags#ToDiscoveryClient(). // see https://issue.k8s.io/86149 - config.Burst = 100 + config.Burst = defaultBurst } codec := runtime.NoopEncoder{Decoder: scheme.Codecs.UniversalDecoder()} config.NegotiatedSerializer = serializer.NegotiatedSerializerWrapper(runtime.SerializerInfo{Serializer: codec}) From 4aac6a7c9c931d76c1678fdeea74aabb3a51748d Mon Sep 17 00:00:00 2001 From: Alper Rifat Ulucinar Date: Thu, 14 Jul 2022 09:58:55 +0300 Subject: [PATCH 2/2] Bump discovery burst of default ConfigFlags to 300 Signed-off-by: Alper Rifat Ulucinar Kubernetes-commit: 45f653e3db6a120d7cafaf2a9262fb3c8a2e22a2 --- discovery/discovery_client.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/discovery/discovery_client.go b/discovery/discovery_client.go index a123aa73..ec7ebf05 100644 --- a/discovery/discovery_client.go +++ b/discovery/discovery_client.go @@ -459,9 +459,8 @@ func setDiscoveryDefaults(config *restclient.Config) error { if config.Timeout == 0 { config.Timeout = defaultTimeout } - // if a burst limit is not already configured and - // an avg. rate of `defaultBurst` qps is not already configured - if config.Burst == 0 && config.QPS < defaultBurst { + // if a burst limit is not already configured + if config.Burst == 0 { // discovery is expected to be bursty, increase the default burst // to accommodate looking up resource info for many API groups. // matches burst set by ConfigFlags#ToDiscoveryClient().