github/client-go
1
0
Fork 0
mirror of https://github.com/kubernetes/client-go.git synced 2025-06-26 23:17:34 +00:00
Code Issues Projects Releases Wiki Activity

modify the elements in the array directly without allocating a new array

Browse Source 
Kubernetes-commit: 238fce9357634502badbcc3704b0655cf8c378c3
This commit is contained in:
scott 2021-01-12 19:58:21 +08:00 committed by Kubernetes Publisher
parent cfd0d8a109
commit c7901fa3e4
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tools/cache/delta_fifo.go vendored
View File

@ -373,13 +373,8 @@ func dedupDeltas(deltas Deltas) Deltas {
a := &deltas[n-1] a := &deltas[n-1]
b := &deltas[n-2] b := &deltas[n-2]
if out := isDup(a, b); out != nil { if out := isDup(a, b); out != nil {
// `a` and `b` are duplicates. Only keep the one returned from isDup(). deltas[n-2] = *out
// TODO: This extra array allocation and copy seems unnecessary if return deltas[:n-1]
// all we do to dedup is compare the new delta with the last element
// in `items`, which could be done by mutating `items` directly.
// Might be worth profiling and investigating if it is safe to optimize.
d := append(Deltas{}, deltas[:n-2]...)
return append(d, *out)
} }
return deltas return deltas
} }