From 4fa8366691ab38c7c1a4a22eebf3947552aab2e0 Mon Sep 17 00:00:00 2001 From: Lukasz Szaszkiewicz Date: Mon, 17 Nov 2025 09:25:33 +0100 Subject: [PATCH] client-go/reflector: Improve WatchListClient disabled log message for clarity Kubernetes-commit: f4c24b5ef52272fe5e473e92fe5f98bee844f8aa --- tools/cache/reflector.go | 3 +-- util/watchlist/watch_list.go | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/cache/reflector.go b/tools/cache/reflector.go index af2c7a22d..694a77fce 100644 --- a/tools/cache/reflector.go +++ b/tools/cache/reflector.go @@ -302,8 +302,7 @@ func NewReflectorWithOptions(lw ListerWatcher, expectedType interface{}, store R // Using klog.TODO() here because switching to a caller-provided contextual logger // would require an API change and updating all existing call sites. klog.TODO().V(2).Info( - "The provided ListWatcher doesn't support WatchList semantics. The feature will be disabled. If you are using a custom client, check the documentation of watchlist.DoesClientNotSupportWatchListSemantics() method", - "listWatcherType", fmt.Sprintf("%T", lw), + "The client used to build this informer/reflector doesn't support WatchList semantics. The feature will be disabled. This is expected in unit tests but not in production. For details, see the documentation of watchlist.DoesClientNotSupportWatchListSemantics().", "feature", clientfeatures.WatchListClient, ) r.useWatchList = false diff --git a/util/watchlist/watch_list.go b/util/watchlist/watch_list.go index 1551a49f7..3641f3bae 100644 --- a/util/watchlist/watch_list.go +++ b/util/watchlist/watch_list.go @@ -90,6 +90,9 @@ type unSupportedWatchListSemantics interface { // // A client does NOT support WatchList only if // it implements `IsWatchListSemanticsUnSupported` and that returns true. +// +// For an explanation of how WatchList works, see: +// https://kubernetes.io/docs/reference/using-api/api-concepts/#streaming-lists func DoesClientNotSupportWatchListSemantics(client any) bool { lw, ok := client.(unSupportedWatchListSemantics) if !ok {