github/client-go
1
0
Fork 0
mirror of https://github.com/kubernetes/client-go.git synced 2025-09-03 08:04:45 +00:00
Code Issues Projects Releases Wiki Activity

ensure tls server name is used in transport

Browse Source 
Kubernetes-commit: 6f657424743e93d064f8975a930941ba73f53110
This commit is contained in:
Jordan Liggitt
2018-04-17 00:59:27 -04:00
committed by Kubernetes Publisher
parent 015563ab58
commit d23614d7ea
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
transport/transport.go
View File

@@ -52,7 +52,7 @@ func New(config *Config) (http.RoundTripper, error) {
// TLSConfigFor returns a tls.Config that will provide the transport level security defined // TLSConfigFor returns a tls.Config that will provide the transport level security defined
// by the provided Config. Will return nil if no transport level security is requested. // by the provided Config. Will return nil if no transport level security is requested.
func TLSConfigFor(c *Config) (*tls.Config, error) { func TLSConfigFor(c *Config) (*tls.Config, error) {
if !(c.HasCA() || c.HasCertAuth() || c.TLS.Insecure) { if !(c.HasCA() || c.HasCertAuth() || c.TLS.Insecure || len(c.TLS.ServerName) > 0) {
return nil, nil return nil, nil
} }
if c.HasCA() && c.TLS.Insecure { if c.HasCA() && c.TLS.Insecure {

7
transport/transport_test.go
View File

@@ -101,6 +101,13 @@ func TestNew(t *testing.T) {
Config: &Config{}, Config: &Config{},
}, },
"server name": {
TLS: true,
Config: &Config{TLS: TLSConfig{
ServerName: "foo",
}},
},
"ca transport": { "ca transport": {
TLS: true, TLS: true,
Config: &Config{ Config: &Config{