diff --git a/discovery/cached/disk/cached_discovery.go b/discovery/cached/disk/cached_discovery.go index b759af4e..07f8182e 100644 --- a/discovery/cached/disk/cached_discovery.go +++ b/discovery/cached/disk/cached_discovery.go @@ -90,13 +90,6 @@ func (d *CachedDiscoveryClient) ServerResourcesForGroupVersion(groupVersion stri return liveResources, nil } -// ServerResources returns the supported resources for all groups and versions. -// Deprecated: use ServerGroupsAndResources instead. -func (d *CachedDiscoveryClient) ServerResources() ([]*metav1.APIResourceList, error) { - _, rs, err := discovery.ServerGroupsAndResources(d) - return rs, err -} - // ServerGroupsAndResources returns the supported groups and resources for all groups and versions. func (d *CachedDiscoveryClient) ServerGroupsAndResources() ([]*metav1.APIGroup, []*metav1.APIResourceList, error) { return discovery.ServerGroupsAndResources(d) diff --git a/discovery/cached/disk/cached_discovery_test.go b/discovery/cached/disk/cached_discovery_test.go index cbea2b90..35239c2c 100644 --- a/discovery/cached/disk/cached_discovery_test.go +++ b/discovery/cached/disk/cached_discovery_test.go @@ -54,11 +54,11 @@ func TestCachedDiscoveryClient_Fresh(t *testing.T) { assert.True(cdc.Fresh(), "should be fresh after another groups call") assert.Equal(c.groupCalls, 1) - cdc.ServerResources() + cdc.ServerGroupsAndResources() assert.True(cdc.Fresh(), "should be fresh after resources call") assert.Equal(c.resourceCalls, 1) - cdc.ServerResources() + cdc.ServerGroupsAndResources() assert.True(cdc.Fresh(), "should be fresh after another resources call") assert.Equal(c.resourceCalls, 1) @@ -67,14 +67,14 @@ func TestCachedDiscoveryClient_Fresh(t *testing.T) { assert.False(cdc.Fresh(), "should NOT be fresh after recreation with existing groups cache") assert.Equal(c.groupCalls, 1) - cdc.ServerResources() + cdc.ServerGroupsAndResources() assert.False(cdc.Fresh(), "should NOT be fresh after recreation with existing resources cache") assert.Equal(c.resourceCalls, 1) cdc.Invalidate() assert.True(cdc.Fresh(), "should be fresh after cache invalidation") - cdc.ServerResources() + cdc.ServerGroupsAndResources() assert.True(cdc.Fresh(), "should ignore existing resources cache after invalidation") assert.Equal(c.resourceCalls, 2) } @@ -172,12 +172,6 @@ func (c *fakeDiscoveryClient) ServerResourcesForGroupVersion(groupVersion string return nil, errors.NewNotFound(schema.GroupResource{}, "") } -// Deprecated: use ServerGroupsAndResources instead. -func (c *fakeDiscoveryClient) ServerResources() ([]*metav1.APIResourceList, error) { - _, rs, err := c.ServerGroupsAndResources() - return rs, err -} - func (c *fakeDiscoveryClient) ServerGroupsAndResources() ([]*metav1.APIGroup, []*metav1.APIResourceList, error) { c.resourceCalls = c.resourceCalls + 1 diff --git a/discovery/cached/memory/memcache.go b/discovery/cached/memory/memcache.go index 8b731759..7795afeb 100644 --- a/discovery/cached/memory/memcache.go +++ b/discovery/cached/memory/memcache.go @@ -107,12 +107,6 @@ func (d *memCacheClient) ServerResourcesForGroupVersion(groupVersion string) (*m return cachedVal.resourceList, cachedVal.err } -// ServerResources returns the supported resources for all groups and versions. -// Deprecated: use ServerGroupsAndResources instead. -func (d *memCacheClient) ServerResources() ([]*metav1.APIResourceList, error) { - return discovery.ServerResources(d) -} - // ServerGroupsAndResources returns the groups and supported resources for all groups and versions. func (d *memCacheClient) ServerGroupsAndResources() ([]*metav1.APIGroup, []*metav1.APIResourceList, error) { return discovery.ServerGroupsAndResources(d) diff --git a/discovery/discovery_client.go b/discovery/discovery_client.go index ce5eda14..9ea89755 100644 --- a/discovery/discovery_client.go +++ b/discovery/discovery_client.go @@ -90,13 +90,6 @@ type ServerGroupsInterface interface { type ServerResourcesInterface interface { // ServerResourcesForGroupVersion returns the supported resources for a group and version. ServerResourcesForGroupVersion(groupVersion string) (*metav1.APIResourceList, error) - // ServerResources returns the supported resources for all groups and versions. - // - // The returned resource list might be non-nil with partial results even in the case of - // non-nil error. - // - // Deprecated: use ServerGroupsAndResources instead. - ServerResources() ([]*metav1.APIResourceList, error) // ServerGroupsAndResources returns the supported groups and resources for all groups and versions. // // The returned group and resource lists might be non-nil with partial results even in the @@ -210,13 +203,6 @@ func (d *DiscoveryClient) ServerResourcesForGroupVersion(groupVersion string) (r return resources, nil } -// ServerResources returns the supported resources for all groups and versions. -// Deprecated: use ServerGroupsAndResources instead. -func (d *DiscoveryClient) ServerResources() ([]*metav1.APIResourceList, error) { - _, rs, err := d.ServerGroupsAndResources() - return rs, err -} - // ServerGroupsAndResources returns the supported resources for all groups and versions. func (d *DiscoveryClient) ServerGroupsAndResources() ([]*metav1.APIGroup, []*metav1.APIResourceList, error) { return withRetries(defaultRetries, func() ([]*metav1.APIGroup, []*metav1.APIResourceList, error) { @@ -247,13 +233,6 @@ func IsGroupDiscoveryFailedError(err error) bool { return err != nil && ok } -// ServerResources uses the provided discovery interface to look up supported resources for all groups and versions. -// Deprecated: use ServerGroupsAndResources instead. -func ServerResources(d DiscoveryInterface) ([]*metav1.APIResourceList, error) { - _, rs, err := ServerGroupsAndResources(d) - return rs, err -} - func ServerGroupsAndResources(d DiscoveryInterface) ([]*metav1.APIGroup, []*metav1.APIResourceList, error) { sgs, err := d.ServerGroups() if sgs == nil { diff --git a/discovery/discovery_client_test.go b/discovery/discovery_client_test.go index 4d16f8df..f1006beb 100644 --- a/discovery/discovery_client_test.go +++ b/discovery/discovery_client_test.go @@ -164,7 +164,7 @@ func TestGetServerResourcesWithV1Server(t *testing.T) { defer server.Close() client := NewDiscoveryClientForConfigOrDie(&restclient.Config{Host: server.URL}) // ServerResources should not return an error even if server returns error at /api/v1. - serverResources, err := client.ServerResources() + _, serverResources, err := client.ServerGroupsAndResources() if err != nil { t.Errorf("unexpected error: %v", err) } @@ -174,7 +174,7 @@ func TestGetServerResourcesWithV1Server(t *testing.T) { } } -func TestGetServerResources(t *testing.T) { +func TestGetServerResourcesForGroupVersion(t *testing.T) { stable := metav1.APIResourceList{ GroupVersion: "v1", APIResources: []metav1.APIResource{ @@ -365,7 +365,7 @@ func TestGetServerResources(t *testing.T) { client := NewDiscoveryClientForConfigOrDie(&restclient.Config{Host: server.URL}) start := time.Now() - serverResources, err := client.ServerResources() + _, serverResources, err := client.ServerGroupsAndResources() if err != nil { t.Errorf("unexpected error: %v", err) } diff --git a/discovery/fake/discovery.go b/discovery/fake/discovery.go index e75c988c..ea875955 100644 --- a/discovery/fake/discovery.go +++ b/discovery/fake/discovery.go @@ -60,13 +60,6 @@ func (c *FakeDiscovery) ServerResourcesForGroupVersion(groupVersion string) (*me }} } -// ServerResources returns the supported resources for all groups and versions. -// Deprecated: use ServerGroupsAndResources instead. -func (c *FakeDiscovery) ServerResources() ([]*metav1.APIResourceList, error) { - _, rs, err := c.ServerGroupsAndResources() - return rs, err -} - // ServerGroupsAndResources returns the supported groups and resources for all groups and versions. func (c *FakeDiscovery) ServerGroupsAndResources() ([]*metav1.APIGroup, []*metav1.APIResourceList, error) { sgs, err := c.ServerGroups() diff --git a/go.mod b/go.mod index d25e94a7..af7086af 100644 --- a/go.mod +++ b/go.mod @@ -31,7 +31,7 @@ require ( golang.org/x/time v0.0.0-20220210224613-90d013bbcef8 google.golang.org/protobuf v1.27.1 k8s.io/api v0.0.0-20220324210930-df53a95c65aa - k8s.io/apimachinery v0.0.0-20220326010739-df7fbf8e030b + k8s.io/apimachinery v0.0.0-20220326050748-1a826352d1a6 k8s.io/klog/v2 v2.60.1 k8s.io/kube-openapi v0.0.0-20220323210520-29d726468e05 k8s.io/utils v0.0.0-20220210201930-3a6ce19ff2f9 @@ -41,5 +41,5 @@ require ( replace ( k8s.io/api => k8s.io/api v0.0.0-20220324210930-df53a95c65aa - k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20220326010739-df7fbf8e030b + k8s.io/apimachinery => k8s.io/apimachinery v0.0.0-20220326050748-1a826352d1a6 ) diff --git a/go.sum b/go.sum index a568c1e5..34ca62a7 100644 --- a/go.sum +++ b/go.sum @@ -615,8 +615,8 @@ honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9 honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k= k8s.io/api v0.0.0-20220324210930-df53a95c65aa h1:NzCktMsy22Y/ddoBN/kf96kFaklITIHNfA1sRv6UofA= k8s.io/api v0.0.0-20220324210930-df53a95c65aa/go.mod h1:Ea6ReZGsqdWOZc66t7sHO58lTcUGyQcMJ3UfsqOnKfM= -k8s.io/apimachinery v0.0.0-20220326010739-df7fbf8e030b h1:KdYn+MuhEqOjmABS52f4cQuWkxJ8DDkAgw6BkHfjD+0= -k8s.io/apimachinery v0.0.0-20220326010739-df7fbf8e030b/go.mod h1:V4ECjDypP1xQpnL3N9yFzlbGZgd8tLKouJnRyAn/Zyw= +k8s.io/apimachinery v0.0.0-20220326050748-1a826352d1a6 h1:6HO0jOM6IZFgU8JjScwE6mpiM6GADuTmpHOsFXYlGXc= +k8s.io/apimachinery v0.0.0-20220326050748-1a826352d1a6/go.mod h1:V4ECjDypP1xQpnL3N9yFzlbGZgd8tLKouJnRyAn/Zyw= k8s.io/gengo v0.0.0-20210813121822-485abfe95c7c/go.mod h1:FiNAH4ZV3gBg2Kwh89tzAEV2be7d5xI0vBa/VySYy3E= k8s.io/klog/v2 v2.0.0/go.mod h1:PBfzABfn139FHAV07az/IF9Wp1bkk3vpT2XSJ76fSDE= k8s.io/klog/v2 v2.2.0/go.mod h1:Od+F08eJP+W3HUb4pSrPpgp9DGU4GzlpG/TmITuYh/Y= diff --git a/restmapper/discovery_test.go b/restmapper/discovery_test.go index e14ccc71..722d38ac 100644 --- a/restmapper/discovery_test.go +++ b/restmapper/discovery_test.go @@ -401,10 +401,6 @@ func (d *fakeFailingDiscovery) ServerResourcesForGroupVersion(groupVersion strin return nil, fmt.Errorf("not found") } -func (d *fakeFailingDiscovery) ServerResources() ([]*metav1.APIResourceList, error) { - return ServerResources(d) -} - func (d *fakeFailingDiscovery) ServerPreferredResources() ([]*metav1.APIResourceList, error) { return ServerPreferredResources(d) } @@ -464,11 +460,6 @@ func (c *fakeCachedDiscoveryInterface) ServerResourcesForGroupVersion(groupVersi return nil, errors.NewNotFound(schema.GroupResource{}, "") } -// Deprecated: use ServerGroupsAndResources instead. -func (c *fakeCachedDiscoveryInterface) ServerResources() ([]*metav1.APIResourceList, error) { - return ServerResources(c) -} - func (c *fakeCachedDiscoveryInterface) ServerPreferredResources() ([]*metav1.APIResourceList, error) { if c.enabledGroupA { return []*metav1.APIResourceList{ diff --git a/restmapper/shortcut_test.go b/restmapper/shortcut_test.go index f0fd1f37..fc56ce47 100644 --- a/restmapper/shortcut_test.go +++ b/restmapper/shortcut_test.go @@ -265,12 +265,6 @@ func (c *fakeDiscoveryClient) ServerResourcesForGroupVersion(groupVersion string return nil, errors.NewNotFound(schema.GroupResource{}, "") } -// Deprecated: use ServerGroupsAndResources instead. -func (c *fakeDiscoveryClient) ServerResources() ([]*metav1.APIResourceList, error) { - _, rs, err := c.ServerGroupsAndResources() - return rs, err -} - func (c *fakeDiscoveryClient) ServerGroupsAndResources() ([]*metav1.APIGroup, []*metav1.APIResourceList, error) { sgs, err := c.ServerGroups() if err != nil {