github/client-go
1
0
Fork 0
mirror of https://github.com/kubernetes/client-go.git synced 2025-09-13 13:52:01 +00:00
Code Issues Projects Releases Wiki Activity

set the timeout to Get method

Browse Source 
Kubernetes-commit: 300c7b815a2eb9598c53c0b386715650f5052804
This commit is contained in:
Keisuke Ishigami
2025-07-17 22:33:32 +09:00
committed by Kubernetes Publisher
parent be4c8bc002
commit e36950929b
1 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tools/leaderelection/leaderelection.go
View File

@@ -307,9 +307,10 @@ func (le *LeaderElector) renew(ctx context.Context) {
// release attempts to release the leader lease if we have acquired it. // release attempts to release the leader lease if we have acquired it.
func (le *LeaderElector) release() bool { func (le *LeaderElector) release() bool {
ctx := context.Background() ctx := context.Background()
timeoutCtx, timeoutCancel := context.WithTimeout(ctx, le.config.RenewDeadline)
defer timeoutCancel()
// update the resourceVersion of lease // update the resourceVersion of lease
oldLeaderElectionRecord, _, err := le.config.Lock.Get(ctx) oldLeaderElectionRecord, _, err := le.config.Lock.Get(timeoutCtx)
if err != nil { if err != nil {
if !errors.IsNotFound(err) { if !errors.IsNotFound(err) {
klog.Errorf("error retrieving resource lock %v: %v", le.config.Lock.Describe(), err) klog.Errorf("error retrieving resource lock %v: %v", le.config.Lock.Describe(), err)
@@ -329,9 +330,6 @@ func (le *LeaderElector) release() bool {
RenewTime: now, RenewTime: now,
AcquireTime: now, AcquireTime: now,
} }
timeoutCtx, timeoutCancel := context.WithTimeout(ctx, le.config.RenewDeadline)
defer timeoutCancel()
if err := le.config.Lock.Update(timeoutCtx, leaderElectionRecord); err != nil { if err := le.config.Lock.Update(timeoutCtx, leaderElectionRecord); err != nil {
klog.Errorf("Failed to release lock: %v", err) klog.Errorf("Failed to release lock: %v", err)
return false return false