github/client-go
1
0
Fork 0
mirror of https://github.com/kubernetes/client-go.git synced 2025-08-16 22:36:48 +00:00
Code Issues Projects Releases Wiki Activity

Fix duplicate code block of ListAll function

Browse Source 
Kubernetes-commit: d8db1e9ba3c110012def6faa5579ad3abb71a6a6
This commit is contained in:
astraw99 2022-03-24 14:47:20 +08:00 committed by Kubernetes Publisher
parent 42a0e1ca70
commit f549acf3ce
1 changed files with 3 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/cache/listers.go vendored
View File

@ -53,24 +53,8 @@ func ListAll(store Store, selector labels.Selector, appendFn AppendFunc) error {
// ListAllByNamespace used to list items belongs to namespace from Indexer. // ListAllByNamespace used to list items belongs to namespace from Indexer.
func ListAllByNamespace(indexer Indexer, namespace string, selector labels.Selector, appendFn AppendFunc) error { func ListAllByNamespace(indexer Indexer, namespace string, selector labels.Selector, appendFn AppendFunc) error {
selectAll := selector.Empty()
if namespace == metav1.NamespaceAll { if namespace == metav1.NamespaceAll {
for _, m := range indexer.List() { return ListAll(indexer, selector, appendFn)
if selectAll {
// Avoid computing labels of the objects to speed up common flows
// of listing all objects.
appendFn(m)
continue
}
metadata, err := meta.Accessor(m)
if err != nil {
return err
}
if selector.Matches(labels.Set(metadata.GetLabels())) {
appendFn(m)
}
}
return nil
} }
items, err := indexer.Index(NamespaceIndex, &metav1.ObjectMeta{Namespace: namespace}) items, err := indexer.Index(NamespaceIndex, &metav1.ObjectMeta{Namespace: namespace})
@ -89,6 +73,8 @@ func ListAllByNamespace(indexer Indexer, namespace string, selector labels.Selec
} }
return nil return nil
} }
selectAll := selector.Empty()
for _, m := range items { for _, m := range items {
if selectAll { if selectAll {
// Avoid computing labels of the objects to speed up common flows // Avoid computing labels of the objects to speed up common flows