From dc29e94395ea546871462bf00311b71740b93cd6 Mon Sep 17 00:00:00 2001 From: yshngg Date: Fri, 29 Aug 2025 17:02:56 +0800 Subject: [PATCH] refactor(event): simplify conditional logic in event handling for both v1 and eventsv1 APIs Signed-off-by: yshngg Kubernetes-commit: 7685612b9c24c3129e0e17a6f6874b5902de02a1 --- tools/events/event_broadcaster.go | 2 +- tools/record/event.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/events/event_broadcaster.go b/tools/events/event_broadcaster.go index 94c2012b8..ff6b2c4fa 100644 --- a/tools/events/event_broadcaster.go +++ b/tools/events/event_broadcaster.go @@ -240,7 +240,7 @@ func recordEvent(ctx context.Context, sink EventSink, event *eventsv1.Event) (*e newEvent, err = sink.Patch(ctx, event, patch) } // Update can fail because the event may have been removed and it no longer exists. - if !isEventSeries || (isEventSeries && util.IsKeyNotFoundError(err)) { + if !isEventSeries || util.IsKeyNotFoundError(err) { // Making sure that ResourceVersion is empty on creation event.ResourceVersion = "" newEvent, err = sink.Create(ctx, event) diff --git a/tools/record/event.go b/tools/record/event.go index f97c5d612..58322d44d 100644 --- a/tools/record/event.go +++ b/tools/record/event.go @@ -334,7 +334,7 @@ func recordEvent(ctx context.Context, sink EventSink, event *v1.Event, patch []b newEvent, err = sink.Patch(event, patch) } // Update can fail because the event may have been removed and it no longer exists. - if !updateExistingEvent || (updateExistingEvent && util.IsKeyNotFoundError(err)) { + if !updateExistingEvent || util.IsKeyNotFoundError(err) { // Making sure that ResourceVersion is empty on creation event.ResourceVersion = "" newEvent, err = sink.Create(event)