mirror of
https://github.com/kubernetes/client-go.git
synced 2025-08-12 20:45:42 +00:00
3595e5242a
Using StartRecordingToSinkWithContext instead of StartRecordingToSink and StartLogging instead of StartStructuredLogging has several advantages: - Spawned goroutines no longer get stuck for extended periods of time during shutdown when passing in a context that gets canceled. - Log output can be directed towards a specific logger instead of the global default, for example one which writes to a testing.T instance. - The new methods return an error when something went wrong instead of merely recording the error. That last point is the reason for deprecating the old methods instead of merely adding new alternatives. Setting a context when constructing an EventBroadcaster makes calling Shutdown optional. It can also be used to specify the logger. Both EventRecorder interfaces in tools/events and tools/record now have a WithLogger helper. Using that method is optional, but recommended to support contextual logging properly. Without it, errors that occur while emitting an event are not associated with the caller. Kubernetes-commit: 27a68aee3a48340f7c14235f7fc24aa69aaeb8f6
106 lines
2.9 KiB
Go
106 lines
2.9 KiB
Go
/*
|
|
Copyright 2022 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package events
|
|
|
|
import (
|
|
"context"
|
|
"reflect"
|
|
"testing"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
eventsv1 "k8s.io/api/events/v1"
|
|
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
|
|
"k8s.io/client-go/kubernetes/fake"
|
|
"k8s.io/klog/v2/ktesting"
|
|
)
|
|
|
|
func TestRecordEventToSink(t *testing.T) {
|
|
nonIsomorphicEvent := eventsv1.Event{
|
|
ObjectMeta: metav1.ObjectMeta{
|
|
Name: "test",
|
|
Namespace: metav1.NamespaceDefault,
|
|
},
|
|
Series: nil,
|
|
}
|
|
|
|
isomorphicEvent := *nonIsomorphicEvent.DeepCopy()
|
|
isomorphicEvent.Series = &eventsv1.EventSeries{Count: 2}
|
|
|
|
testCases := []struct {
|
|
name string
|
|
eventsToRecord []eventsv1.Event
|
|
expectedRecordedEvent eventsv1.Event
|
|
}{
|
|
{
|
|
name: "record one Event",
|
|
eventsToRecord: []eventsv1.Event{
|
|
nonIsomorphicEvent,
|
|
},
|
|
expectedRecordedEvent: nonIsomorphicEvent,
|
|
},
|
|
{
|
|
name: "record one Event followed by an isomorphic one",
|
|
eventsToRecord: []eventsv1.Event{
|
|
nonIsomorphicEvent,
|
|
isomorphicEvent,
|
|
},
|
|
expectedRecordedEvent: isomorphicEvent,
|
|
},
|
|
{
|
|
name: "record one isomorphic Event before the original",
|
|
eventsToRecord: []eventsv1.Event{
|
|
isomorphicEvent,
|
|
nonIsomorphicEvent,
|
|
},
|
|
expectedRecordedEvent: isomorphicEvent,
|
|
},
|
|
{
|
|
name: "record one isomorphic Event without one already existing",
|
|
eventsToRecord: []eventsv1.Event{
|
|
isomorphicEvent,
|
|
},
|
|
expectedRecordedEvent: isomorphicEvent,
|
|
},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
_, ctx := ktesting.NewTestContext(t)
|
|
kubeClient := fake.NewSimpleClientset()
|
|
eventSink := &EventSinkImpl{Interface: kubeClient.EventsV1()}
|
|
|
|
for _, ev := range tc.eventsToRecord {
|
|
recordEvent(ctx, eventSink, &ev)
|
|
}
|
|
|
|
recordedEvents, err := kubeClient.EventsV1().Events(metav1.NamespaceDefault).List(context.TODO(), metav1.ListOptions{})
|
|
if err != nil {
|
|
t.Errorf("expected to be able to list Events from fake client")
|
|
}
|
|
|
|
if len(recordedEvents.Items) != 1 {
|
|
t.Errorf("expected one Event to be recorded, found: %d", len(recordedEvents.Items))
|
|
}
|
|
|
|
recordedEvent := recordedEvents.Items[0]
|
|
if !reflect.DeepEqual(recordedEvent, tc.expectedRecordedEvent) {
|
|
t.Errorf("expected to have recorded Event: %#+v, got: %#+v\n diff: %s", tc.expectedRecordedEvent, recordedEvent, cmp.Diff(tc.expectedRecordedEvent, recordedEvent))
|
|
}
|
|
})
|
|
}
|
|
}
|