Patrick Ohly 40cace856c client-go/tools/cache: fix TestAddWhileActive ...

4638ba971661497b147906b8977ae206c9dd6e44 added tracking of the goroutine which
executes informer.Run. In the TestAddWhileActive the original `go
informer.Run()` was left in place, causing a data race between the two
`informer.Run` instances:

==================
WARNING: DATA RACE
Read at 0x00c000262398 by goroutine 5302:
  k8s.io/client-go/tools/cache.(*controller).RunWithContext()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/controller.go:162 +0x1ad
  k8s.io/client-go/tools/cache.(*sharedIndexInformer).RunWithContext()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:584 +0x6c5
  k8s.io/client-go/tools/cache.(*sharedIndexInformer).Run()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:527 +0x48
  k8s.io/client-go/tools/cache.TestAddWhileActive.gowrap1()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go:1080 +0x17

Previous write at 0x00c000262398 by goroutine 5301:
  k8s.io/client-go/tools/cache.New()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/controller.go:142 +0x9de
  k8s.io/client-go/tools/cache.(*sharedIndexInformer).RunWithContext.func1()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:562 +0xa78
  k8s.io/client-go/tools/cache.(*sharedIndexInformer).RunWithContext()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:565 +0x119
  k8s.io/client-go/tools/cache.(*sharedIndexInformer).Run()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer.go:527 +0x44
  k8s.io/client-go/tools/cache.(*sharedIndexInformer).Run-fm()
      <autogenerated>:1 +0x17
  k8s.io/client-go/tools/cache.TestAddWhileActive.(*Group).StartWithChannel.func2()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/util/wait/wait.go:55 +0x38
  k8s.io/apimachinery/pkg/util/wait.(*Group).Start.func1()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/util/wait/wait.go:72 +0x86

Goroutine 5302 (running) created at:
  k8s.io/client-go/tools/cache.TestAddWhileActive()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go:1080 +0x93e
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      /usr/local/go/src/testing/testing.go:1743 +0x44

Goroutine 5301 (running) created at:
  k8s.io/apimachinery/pkg/util/wait.(*Group).Start()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/util/wait/wait.go:70 +0xe4
  k8s.io/apimachinery/pkg/util/wait.(*Group).StartWithChannel()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/apimachinery/pkg/util/wait/wait.go:54 +0x7e6
  k8s.io/client-go/tools/cache.TestAddWhileActive()
      /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/client-go/tools/cache/shared_informer_test.go:1074 +0x6a1
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1690 +0x226
  testing.(*T).Run.gowrap1()
      /usr/local/go/src/testing/testing.go:1743 +0x44
==================

Kubernetes-commit: d66ced5730fa60c04b0a39df58a156b7045585f6

2025-01-14 14:06:31 +01:00

..

synctrack

Properly align synctrack.SingleFileTracker struct

2023-03-13 08:37:13 +01:00

testing

Fix Panic Condition

2022-02-11 14:50:19 -05:00

cache_test.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

controller_test.go

client-go cache: fix TestHammerController

2024-12-29 12:18:50 +01:00

controller.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

delta_fifo_test.go

Change where transformers are called.

2023-03-14 23:05:20 +00:00

delta_fifo.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

doc.go

remove import doc comments

2024-12-02 14:43:58 +01:00

expiration_cache_fakes.go

Migrate to k8s.io/utils/clock in client-go

2021-09-17 11:36:09 +02:00

expiration_cache_test.go

Migrate to k8s.io/utils/clock in client-go

2021-09-17 11:36:09 +02:00

expiration_cache.go

Remove log line from expiration cache

2022-10-04 11:01:37 -07:00

fake_custom_store.go

1. Fix lint errors for the whole directory staging/src/k8s.io/client-go/tools/cache;

2019-07-10 12:00:52 +08:00

fifo_test.go

Enable propagration of HasSynced

2022-11-18 00:12:50 +00:00

fifo.go

Enable propagration of HasSynced

2022-11-18 00:12:50 +00:00

heap_test.go

cleanup: omit comparison with bool constants

2023-09-04 16:59:23 +08:00

heap.go

simplify returning boolean expression in staging/src/k8s.io/client-go/tools

2021-05-24 07:15:36 +00:00

index_test.go

fix index test: multi index check for empty list

2020-11-26 18:23:57 +08:00

index.go

client-go: allow adding indexes after informer starts

2023-03-31 15:57:18 -07:00

listers.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

listwatch.go

Add details to watch interface method comments

2024-06-12 13:06:22 -07:00

main_test.go

client-go/tools/cache: goroutine leak checking

2024-11-28 17:59:36 +01:00

mutation_cache.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

mutation_detector_test.go

Add test timeout to mutation detector test

2021-03-06 18:16:42 -05:00

mutation_detector.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

object-names_test.go

Added conversions to/from NamespacedName

2023-03-22 16:55:07 -04:00

object-names.go

Added conversions to/from NamespacedName

2023-03-22 16:55:07 -04:00

OWNERS

Move ncdc to emeritus

2024-08-17 13:00:07 -04:00

processor_listener_test.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

reflector_data_consistency_detector.go

client-go/reflector: use consistencydetector.IsDataConsistencyDetectionForWatchListEnabled

2024-06-10 23:01:04 +02:00

reflector_metrics.go

Cleanup staticcheck from staging/src/k8s.io/client-go/tools/cache.

2019-09-04 18:32:06 +08:00

reflector_test.go

handle watch for unsafe delete

2024-11-05 20:36:56 -05:00

reflector_watchlist_test.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

reflector.go

Make getter names for reflector fields idiomatic

2024-10-13 20:53:25 +00:00

retry_with_deadline_test.go

Add option to retry internal api error in reflector.

2022-07-25 08:02:54 +00:00

retry_with_deadline.go

Add option to retry internal api error in reflector.

2022-07-25 08:02:54 +00:00

shared_informer_test.go

client-go/tools/cache: fix TestAddWhileActive

2025-01-14 14:06:31 +01:00

shared_informer.go

client-go/tools/cache: add APIs with context parameter

2024-07-26 15:26:00 +02:00

store_test.go

client-go/cache: support errors.Unwrap for KeyError

2021-04-02 10:17:57 +08:00

store.go

Add structured alternatives to strings in client-go/tools/cache

2023-03-22 16:21:17 -04:00

thread_safe_store_test.go

Refactor store index into its structure

2022-05-05 17:30:24 +02:00

thread_safe_store.go

client-go: allow adding indexes after informer starts

2023-03-31 15:57:18 -07:00

undelta_store_test.go

1. Fix lint errors for the whole directory staging/src/k8s.io/client-go/tools/cache;

2019-07-10 12:00:52 +08:00

undelta_store.go

1. Fix lint errors for the whole directory staging/src/k8s.io/client-go/tools/cache;

2019-07-10 12:00:52 +08:00

util_test.go

client-go/tools/cache: goroutine leak checking

2024-11-28 17:59:36 +01:00