mirror of
https://github.com/kubernetes/client-go.git
synced 2026-05-18 21:55:25 +00:00
3ada5c0eb8
The `recorder.PastEventf` method wasn't actually working as advertised. It was supposed to accept a timestamp, which would be used when generating the event. However, as the [source code](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/record/event.go#L316) shows, this `timestamp` was never actually used. In other words, `PastEventf` is identical to `Eventf`. We have two options: one would be to fix `PastEventf` so that it works as advertised. The other would be to delete `PastEventf` and only support `Eventf`. Ultimately, I could only find one use of `PastEventf` in the code base, so I propose we just delete `PastEventf` and convert all uses to `Eventf`. Kubernetes-commit: 92940fa80d67593c7a2333267da4424c8b45ac88
55 lines
1.7 KiB
Go
55 lines
1.7 KiB
Go
/*
|
|
Copyright 2015 The Kubernetes Authors.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package record
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"k8s.io/apimachinery/pkg/runtime"
|
|
)
|
|
|
|
// FakeRecorder is used as a fake during tests. It is thread safe. It is usable
|
|
// when created manually and not by NewFakeRecorder, however all events may be
|
|
// thrown away in this case.
|
|
type FakeRecorder struct {
|
|
Events chan string
|
|
}
|
|
|
|
func (f *FakeRecorder) Event(object runtime.Object, eventtype, reason, message string) {
|
|
if f.Events != nil {
|
|
f.Events <- fmt.Sprintf("%s %s %s", eventtype, reason, message)
|
|
}
|
|
}
|
|
|
|
func (f *FakeRecorder) Eventf(object runtime.Object, eventtype, reason, messageFmt string, args ...interface{}) {
|
|
if f.Events != nil {
|
|
f.Events <- fmt.Sprintf(eventtype+" "+reason+" "+messageFmt, args...)
|
|
}
|
|
}
|
|
|
|
func (f *FakeRecorder) AnnotatedEventf(object runtime.Object, annotations map[string]string, eventtype, reason, messageFmt string, args ...interface{}) {
|
|
f.Eventf(object, eventtype, reason, messageFmt, args)
|
|
}
|
|
|
|
// NewFakeRecorder creates new fake event recorder with event channel with
|
|
// buffer of given size.
|
|
func NewFakeRecorder(bufferSize int) *FakeRecorder {
|
|
return &FakeRecorder{
|
|
Events: make(chan string, bufferSize),
|
|
}
|
|
}
|