Files
client-go/features/features_test.go
Siyuan Zhang 504fb21b89 change client go default features to versioned
so that their enablement can be consistent with emulated version.

Signed-off-by: Siyuan Zhang <sizhang@google.com>

Kubernetes-commit: d4c6e0bfd04a9efb1ddb33afdcaa49eb8695d8e5
2025-10-31 10:04:06 -05:00

109 lines
3.6 KiB
Go

/*
Copyright 2024 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package features
import (
"reflect"
"testing"
"github.com/stretchr/testify/require"
"k8s.io/apimachinery/pkg/util/version"
)
// TestAddFeaturesToExistingFeatureGates ensures that
// the defaultVersionedKubernetesFeatureGates are added to a test feature gates registry.
func TestAddFeaturesToExistingFeatureGates(t *testing.T) {
fakeFeatureGates := &fakeRegistry{}
require.NoError(t, AddFeaturesToExistingFeatureGates(fakeFeatureGates))
require.Equal(t, unversionedFeatureGates(defaultVersionedKubernetesFeatureGates), fakeFeatureGates.specs)
}
// TestAddVersionedFeaturesToExistingFeatureGates ensures that
// the defaultVersionedKubernetesFeatureGates are added to a versioned test feature gates registry.
func TestAddVersionedFeaturesToExistingFeatureGates(t *testing.T) {
fakeFeatureGates := &fakeVersionedRegistry{}
require.NoError(t, AddVersionedFeaturesToExistingFeatureGates(fakeFeatureGates))
require.Equal(t, defaultVersionedKubernetesFeatureGates, fakeFeatureGates.specs)
}
func TestUnversionedFeatureGates(t *testing.T) {
testCases := []struct {
name string
featureGates map[Feature]VersionedSpecs
expected map[Feature]FeatureSpec
}{
{
name: "multiple features",
featureGates: map[Feature]VersionedSpecs{
"AlphaFeature": {
{Version: version.MustParse("1.30"), Default: false, PreRelease: Alpha},
},
"BetaFeature": {
{Version: version.MustParse("1.28"), Default: false, PreRelease: Alpha},
{Version: version.MustParse("1.30"), Default: true, PreRelease: Beta},
},
"GAFeature": {
{Version: version.MustParse("1.25"), Default: false, PreRelease: Alpha},
{Version: version.MustParse("1.27"), Default: true, PreRelease: Beta},
{Version: version.MustParse("1.29"), Default: true, PreRelease: GA, LockToDefault: true},
},
},
expected: map[Feature]FeatureSpec{
"AlphaFeature": {Default: false, PreRelease: Alpha},
"BetaFeature": {Default: true, PreRelease: Beta},
"GAFeature": {Default: true, PreRelease: GA, LockToDefault: true},
},
},
}
for _, tc := range testCases {
t.Run(tc.name, func(t *testing.T) {
actual := unversionedFeatureGates(tc.featureGates)
if !reflect.DeepEqual(actual, tc.expected) {
t.Errorf("unversionedFeatureGates() = %v, want %v", actual, tc.expected)
}
})
}
}
func TestReplaceFeatureGatesWithWarningIndicator(t *testing.T) {
defaultFeatureGates := FeatureGates()
require.Panics(t, func() { defaultFeatureGates.Enabled("Foo") }, "reading an unregistered feature gate Foo should panic")
if !replaceFeatureGatesWithWarningIndicator(defaultFeatureGates) {
t.Error("replacing the default feature gates after reading a value hasn't produced a warning")
}
}
type fakeRegistry struct {
specs map[Feature]FeatureSpec
}
func (f *fakeRegistry) Add(specs map[Feature]FeatureSpec) error {
f.specs = specs
return nil
}
type fakeVersionedRegistry struct {
specs map[Feature]VersionedSpecs
}
func (f *fakeVersionedRegistry) AddVersioned(specs map[Feature]VersionedSpecs) error {
f.specs = specs
return nil
}