fix: add explicitly UnsupportedHostnqnError for fallback supports

If linux kernel has no hostnqn sysfs file supports, return UnsupportedHostnqnError
and switch to fallback mode which will disconnect all connections at once when
a last controller in a nqn is disconnected.

pkg/nvmf/errors.go

@@ -0,0 +1,36 @@
+/*
+Copyright 2021 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package nvmf
+
+import "fmt"
+
+type NoControllerError struct {
+	Nqn     string
+	Hostnqn string
+}
+
+func (e *NoControllerError) Error() string {
+	return fmt.Sprintf("not found controller: nqn=%s, hostnqn=%s", e.Nqn, e.Hostnqn)
+}
+
+type UnsupportedHostnqnError struct {
+	Target string
+}
+
+func (e *UnsupportedHostnqnError) Error() string {
+	return fmt.Sprintf("unsupported hostnqn sysfs file: target=%s", e.Target)
+}

pkg/nvmf/fabrics.go

@@ -88,85 +88,85 @@ func _disconnect(sysfs_path string) error {
 	return nil
 }
 
-func disconnectSubsysWithHostNqn(nqn, hostnqn, ctrl string) (res bool) {
+func disconnectSubsysWithHostNqn(nqn, hostnqn, ctrl string) error {
 	sysfs_subsysnqn_path := fmt.Sprintf("%s/%s/subsysnqn", SYS_NVMF, ctrl)
 	sysfs_hostnqn_path := fmt.Sprintf("%s/%s/hostnqn", SYS_NVMF, ctrl)
 	sysfs_del_path := fmt.Sprintf("%s/%s/delete_controller", SYS_NVMF, ctrl)
 
 	file, err := os.Open(sysfs_subsysnqn_path)
 	if err != nil {
-		klog.Errorf("Disconnect: open file %s err: %v", file.Name(), err)
+		klog.Errorf("Disconnect: open file %s err: %v", sysfs_subsysnqn_path, err)
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: hostnqn}
 	}
 	defer file.Close()
 
 	lines, err := utils.ReadLinesFromFile(file)
 	if err != nil {
 		klog.Errorf("Disconnect: read file %s err: %v", file.Name(), err)
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: hostnqn}
 	}
 
 	if lines[0] != nqn {
 		klog.Warningf("Disconnect: not this subsystem, skip")
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: hostnqn}
 	}
 
 	file, err = os.Open(sysfs_hostnqn_path)
 	if err != nil {
 		klog.Errorf("Disconnect: open file %s err: %v", sysfs_hostnqn_path, err)
-		return false
+		return &UnsupportedHostnqnError{Target: sysfs_hostnqn_path}
 	}
 	defer file.Close()
 
 	lines, err = utils.ReadLinesFromFile(file)
 	if err != nil {
 		klog.Errorf("Disconnect: read file %s err: %v", file.Name(), err)
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: hostnqn}
 	}
 
 	if lines[0] != hostnqn {
 		klog.Warningf("Disconnect: not this subsystem, skip")
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: hostnqn}
 	}
 
 	err = _disconnect(sysfs_del_path)
 	if err != nil {
 		klog.Errorf("Disconnect: disconnect error: %s", err)
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: hostnqn}
 	}
 
-	return true
+	return nil
 }
 
-func disconnectSubsys(nqn, ctrl string) (res bool) {
+func disconnectSubsys(nqn, ctrl string) error {
 	sysfs_subsysnqn_path := fmt.Sprintf("%s/%s/subsysnqn", SYS_NVMF, ctrl)
 	sysfs_del_path := fmt.Sprintf("%s/%s/delete_controller", SYS_NVMF, ctrl)
 
 	file, err := os.Open(sysfs_subsysnqn_path)
 	if err != nil {
-		klog.Errorf("Disconnect: open file %s err: %v", file.Name(), err)
+		klog.Errorf("Disconnect: open file %s err: %v", sysfs_subsysnqn_path, err)
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: ""}
 	}
 	defer file.Close()
 
 	lines, err := utils.ReadLinesFromFile(file)
 	if err != nil {
 		klog.Errorf("Disconnect: read file %s err: %v", file.Name(), err)
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: ""}
 	}
 
 	if lines[0] != nqn {
 		klog.Warningf("Disconnect: not this subsystem, skip")
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: ""}
 	}
 
 	err = _disconnect(sysfs_del_path)
 	if err != nil {
 		klog.Errorf("Disconnect: disconnect error: %s", err)
-		return false
+		return &NoControllerError{Nqn: nqn, Hostnqn: ""}
 	}
 
-	return true
+	return nil
 }
 
 func disconnectByNqn(nqn, hostnqn string) int {
@@ -180,18 +180,7 @@ func disconnectByNqn(nqn, hostnqn string) int {
 	hostnqnPath := filepath.Join(RUN_NVMF, nqn, b64.StdEncoding.EncodeToString([]byte(hostnqn)))
 	os.Remove(hostnqnPath)
 
-	devices, err := ioutil.ReadDir(SYS_NVMF)
+	// delete nqn directory if has no hostnqn files
-	if err != nil {
-		klog.Errorf("Disconnect: readdir %s err: %s", SYS_NVMF, err)
-		return -ENOENT
-	}
-
-	for _, device := range devices {
-		if disconnectSubsysWithHostNqn(nqn, hostnqn, device.Name()) {
-			ret++
-		}
-	}
-
 	nqnPath := filepath.Join(RUN_NVMF, nqn)
 	hostnqns, err := ioutil.ReadDir(nqnPath)
 	if err != nil {
@@ -199,23 +188,38 @@ func disconnectByNqn(nqn, hostnqn string) int {
 		return -ENOENT
 	}
 	if len(hostnqns) <= 0 {
-		if ret == 0 {
+		os.RemoveAll(nqnPath)
-			klog.Infof("Fallback because you have no hostnqn supports!")
+	}
 
-			devices, err := ioutil.ReadDir(SYS_NVMF)
+	devices, err := ioutil.ReadDir(SYS_NVMF)
-			if err != nil {
+	if err != nil {
-				klog.Errorf("Disconnect: readdir %s err: %s", SYS_NVMF, err)
+		klog.Errorf("Disconnect: readdir %s err: %s", SYS_NVMF, err)
-				return -ENOENT
+		return -ENOENT
-			}
+	}
 
-			for _, device := range devices {
+	for _, device := range devices {
-				if disconnectSubsys(nqn, device.Name()) {
+		if err := disconnectSubsysWithHostNqn(nqn, hostnqn, device.Name()); err != nil {
-					ret++
+			if _, ok := err.(*UnsupportedHostnqnError); ok {
+				klog.Infof("Fallback because you have no hostnqn supports!")
+
+				// disconnect all controllers if has no hostnqn files
+				if len(hostnqns) <= 0 {
+					devices, err := ioutil.ReadDir(SYS_NVMF)
+					if err != nil {
+						klog.Errorf("Disconnect: readdir %s err: %s", SYS_NVMF, err)
+						return -ENOENT
+					}
+
+					for _, device := range devices {
+						if err := disconnectSubsys(nqn, device.Name()); err == nil {
+							ret++
+						}
+					}
 				}
 			}
+		} else {
+			ret++
 		}
-
-		os.RemoveAll(nqnPath)
 	}
 
 	return ret