github/distribution
1
0
Fork 0
mirror of https://github.com/distribution/distribution.git synced 2025-09-12 21:28:59 +00:00
Code Issues Projects Releases Wiki Activity

fix(registry/storage/driver/s3-aws): use a consistent multipart chunk size

Browse Source 
Some S3 compatible object storage systems like R2 require that all
multipart chunks are the same size. This was mostly true before, except
the final chunk was larger than the requested chunk size which causes
uploads to fail.

In addition, the two byte slices have been replaced with a single
*bytes.Buffer and the surrounding code simplified significantly.

Fixes: #3873

Signed-off-by: Thomas Way <thomas@6f.io>
This commit is contained in:
Thomas Way
2024-10-30 21:46:36 +00:00
parent c427f84503
commit 5ee5aaa058
6 changed files with 179 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
docs/content/storage-drivers/s3.md
View File

@@ -80,9 +80,6 @@ Amazon S3 or S3 compatible services for object storage.
`loglevel`: (optional) Valid values are: `off` (default), `debug`, `debugwithsigning`, `debugwithhttpbody`, `debugwithrequestretries`, `debugwithrequesterrors` and `debugwitheventstreambody`. See the [AWS SDK for Go API reference](https://docs.aws.amazon.com/sdk-for-go/api/aws/#LogLevelType) for details.
**NOTE:** Currently the S3 storage driver only supports S3 API compatible storage that
allows parts of a multipart upload to vary in size. [Cloudflare R2 is not supported.](https://developers.cloudflare.com/r2/objects/multipart-objects/#limitations)
## S3 permission scopes
The following AWS policy is required by the registry for push and pull. Make sure to replace `S3_BUCKET_NAME` with the name of your bucket.