github/distribution
1
0
Fork 0
mirror of https://github.com/distribution/distribution.git synced 2025-08-19 23:38:13 +00:00
Code Issues Projects Releases Wiki Activity

storagedriver/s3: Updating comments

Browse Source
This commit is contained in:
Collin Shoop 2021-06-29 08:34:15 -04:00
parent 9618ba7231
commit 8d38cde0f3
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
registry/storage/driver/s3-aws/s3.go
View File

@ -1102,6 +1102,16 @@ func (d *driver) doWalk(parentCtx context.Context, objectCount *int64, path, pre
ctx, done := dcontext.WithTrace(parentCtx)
defer done("s3aws.ListObjectsV2Pages(%s)", path)
// The s3 list object API will list all objects under the starting path recursively, in sorted,
// depth-first ordering https://docs.aws.amazon.com/AmazonS3/latest/userguide/ListingKeysUsingAPIs.html
// S3 does not return directory without the "delimiter":"/" argument passed, but they can to be
// inferred from object paths and then de-duplicated to avoid calling the walk fn redundantly.
// With files returned in sorted depth-first order, directories are inferred in the same order,
// so avoiding redundant directories is a matter of not passing the same directory to the walk fn twice in a row.
// ErrSkipDir is handled by explicitly skipping over any files under the skipped directory. This may sub-optimal
// for extreme edge cases but for the general use case in a registry, this is orders of magnitude
// faster than a more explicit recursive implementation.
listObjectErr := s.ListObjectsV2PagesWithContext(ctx, listObjectsInput, func(objects *s3.ListObjectsV2Output, lastPage bool) bool {
walkInfos := make([]storagedriver.FileInfoInternal, 0, len(objects.Contents))