addressing comments from stevvooe

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
This commit is contained in:
Mike Brown
2017-07-20 20:44:02 -05:00
parent c1532332ad
commit ec2aa05cdf
6 changed files with 86 additions and 144 deletions

View File

@@ -53,12 +53,6 @@ func TestVerifyOCIManifestNonDistributableLayer(t *testing.T) {
cases := []testcase{
{
nonDistributableLayer,
nil,
errMissingURL,
},
{
// regular layers may have foreign urls (non-Distributable Layers)
layer,
[]string{"http://foo/bar"},
nil,
@@ -66,37 +60,37 @@ func TestVerifyOCIManifestNonDistributableLayer(t *testing.T) {
{
nonDistributableLayer,
[]string{"file:///local/file"},
errInvalidURL,
nil,
},
{
nonDistributableLayer,
[]string{"http://foo/bar#baz"},
errInvalidURL,
nil,
},
{
nonDistributableLayer,
[]string{""},
errInvalidURL,
nil,
},
{
nonDistributableLayer,
[]string{"https://foo/bar", ""},
errInvalidURL,
nil,
},
{
nonDistributableLayer,
[]string{"", "https://foo/bar"},
errInvalidURL,
nil,
},
{
nonDistributableLayer,
[]string{"http://nope/bar"},
errInvalidURL,
nil,
},
{
nonDistributableLayer,
[]string{"http://foo/nope"},
errInvalidURL,
nil,
},
{
nonDistributableLayer,