From 03bf027e5c5df6644dc611c21c07c8b37706aefb Mon Sep 17 00:00:00 2001 From: Vaibhav Date: Thu, 13 Feb 2020 06:14:33 +0530 Subject: [PATCH] feat(userspace): Add comments to explain "banned.h". Fixes #1035 Signed-off-by: Vaibhav --- userspace/engine/falco_common.cpp | 2 +- userspace/engine/falco_engine.cpp | 2 +- userspace/engine/falco_utils.cpp | 2 +- userspace/engine/formats.cpp | 2 +- userspace/engine/json_evt.cpp | 2 +- userspace/engine/rules.cpp | 2 +- userspace/engine/ruleset.cpp | 2 +- userspace/engine/token_bucket.cpp | 2 +- userspace/falco/configuration.cpp | 2 +- userspace/falco/event_drops.cpp | 2 +- userspace/falco/falco.cpp | 2 +- userspace/falco/falco_outputs.cpp | 2 +- userspace/falco/grpc_context.cpp | 2 +- userspace/falco/grpc_server.cpp | 2 +- userspace/falco/grpc_server_impl.cpp | 2 +- userspace/falco/logger.cpp | 2 +- userspace/falco/statsfilewriter.cpp | 2 +- userspace/falco/utils.cpp | 2 +- userspace/falco/webserver.cpp | 2 +- 19 files changed, 19 insertions(+), 19 deletions(-) diff --git a/userspace/engine/falco_common.cpp b/userspace/engine/falco_common.cpp index f8cbeb98..e64bca21 100644 --- a/userspace/engine/falco_common.cpp +++ b/userspace/engine/falco_common.cpp @@ -18,7 +18,7 @@ limitations under the License. #include "config_falco_engine.h" #include "falco_common.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used std::vector falco_common::priority_names = { "Emergency", diff --git a/userspace/engine/falco_engine.cpp b/userspace/engine/falco_engine.cpp index aa298a7e..801aea92 100644 --- a/userspace/engine/falco_engine.cpp +++ b/userspace/engine/falco_engine.cpp @@ -32,7 +32,7 @@ extern "C" { } #include "utils.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used string lua_on_event = "on_event"; diff --git a/userspace/engine/falco_utils.cpp b/userspace/engine/falco_utils.cpp index bc0ea08d..513d2e23 100644 --- a/userspace/engine/falco_utils.cpp +++ b/userspace/engine/falco_utils.cpp @@ -18,7 +18,7 @@ limitations under the License. */ #include "falco_utils.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used namespace falco { diff --git a/userspace/engine/formats.cpp b/userspace/engine/formats.cpp index 199c31c7..b09ed9c8 100644 --- a/userspace/engine/formats.cpp +++ b/userspace/engine/formats.cpp @@ -18,7 +18,7 @@ limitations under the License. #include "formats.h" #include "falco_engine.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used sinsp* falco_formats::s_inspector = NULL; diff --git a/userspace/engine/json_evt.cpp b/userspace/engine/json_evt.cpp index 0b2a66f6..50f643d3 100644 --- a/userspace/engine/json_evt.cpp +++ b/userspace/engine/json_evt.cpp @@ -21,7 +21,7 @@ limitations under the License. #include "falco_common.h" #include "json_evt.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used using json = nlohmann::json; using namespace std; diff --git a/userspace/engine/rules.cpp b/userspace/engine/rules.cpp index 914fc4f5..79e0485e 100644 --- a/userspace/engine/rules.cpp +++ b/userspace/engine/rules.cpp @@ -24,7 +24,7 @@ extern "C" { } #include "falco_engine.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used const static struct luaL_reg ll_falco_rules [] = { diff --git a/userspace/engine/ruleset.cpp b/userspace/engine/ruleset.cpp index 127f9a6f..7ed8a004 100644 --- a/userspace/engine/ruleset.cpp +++ b/userspace/engine/ruleset.cpp @@ -15,7 +15,7 @@ limitations under the License. */ #include "ruleset.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used using namespace std; diff --git a/userspace/engine/token_bucket.cpp b/userspace/engine/token_bucket.cpp index b6ec1ac2..04893e48 100644 --- a/userspace/engine/token_bucket.cpp +++ b/userspace/engine/token_bucket.cpp @@ -20,7 +20,7 @@ limitations under the License. #include "token_bucket.h" #include "utils.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used token_bucket::token_bucket(): token_bucket(sinsp_utils::get_current_time_ns) diff --git a/userspace/falco/configuration.cpp b/userspace/falco/configuration.cpp index 32a053fc..f1cd09e0 100644 --- a/userspace/falco/configuration.cpp +++ b/userspace/falco/configuration.cpp @@ -23,7 +23,7 @@ limitations under the License. #include "configuration.h" #include "logger.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used using namespace std; diff --git a/userspace/falco/event_drops.cpp b/userspace/falco/event_drops.cpp index 2f0f9dd0..262d493e 100644 --- a/userspace/falco/event_drops.cpp +++ b/userspace/falco/event_drops.cpp @@ -15,7 +15,7 @@ limitations under the License. */ #include "event_drops.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used syscall_evt_drop_mgr::syscall_evt_drop_mgr(): m_num_syscall_evt_drops(0), diff --git a/userspace/falco/falco.cpp b/userspace/falco/falco.cpp index e4088ae9..d5bb0fdb 100644 --- a/userspace/falco/falco.cpp +++ b/userspace/falco/falco.cpp @@ -45,7 +45,7 @@ limitations under the License. #include "statsfilewriter.h" #include "webserver.h" #include "grpc_server.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used typedef function open_t; diff --git a/userspace/falco/falco_outputs.cpp b/userspace/falco/falco_outputs.cpp index f8334e43..36bbb27d 100644 --- a/userspace/falco/falco_outputs.cpp +++ b/userspace/falco/falco_outputs.cpp @@ -23,7 +23,7 @@ limitations under the License. #include "formats.h" #include "logger.h" #include "falco_output_queue.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used using namespace std; using namespace falco::output; diff --git a/userspace/falco/grpc_context.cpp b/userspace/falco/grpc_context.cpp index cbf01142..c0411e2e 100644 --- a/userspace/falco/grpc_context.cpp +++ b/userspace/falco/grpc_context.cpp @@ -17,7 +17,7 @@ limitations under the License. #include #include "grpc_context.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used falco::grpc::context::context(::grpc::ServerContext* ctx): m_ctx(ctx) diff --git a/userspace/falco/grpc_server.cpp b/userspace/falco/grpc_server.cpp index 0bd53781..9b42cb24 100644 --- a/userspace/falco/grpc_server.cpp +++ b/userspace/falco/grpc_server.cpp @@ -24,7 +24,7 @@ limitations under the License. #include "grpc_server.h" #include "grpc_request_context.h" #include "utils.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used #define REGISTER_STREAM(req, res, svc, rpc, impl, num) \ std::vector> rpc##_contexts(num); \ diff --git a/userspace/falco/grpc_server_impl.cpp b/userspace/falco/grpc_server_impl.cpp index e74cb1e7..cf027bd7 100644 --- a/userspace/falco/grpc_server_impl.cpp +++ b/userspace/falco/grpc_server_impl.cpp @@ -17,7 +17,7 @@ limitations under the License. #include "config_falco.h" #include "grpc_server_impl.h" #include "falco_output_queue.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used bool falco::grpc::server_impl::is_running() { diff --git a/userspace/falco/logger.cpp b/userspace/falco/logger.cpp index cf023a9b..a237d521 100644 --- a/userspace/falco/logger.cpp +++ b/userspace/falco/logger.cpp @@ -19,7 +19,7 @@ limitations under the License. #include "chisel_api.h" #include "falco_common.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used const static struct luaL_reg ll_falco [] = { diff --git a/userspace/falco/statsfilewriter.cpp b/userspace/falco/statsfilewriter.cpp index 9da61f9f..91461dcb 100644 --- a/userspace/falco/statsfilewriter.cpp +++ b/userspace/falco/statsfilewriter.cpp @@ -18,7 +18,7 @@ limitations under the License. #include #include "statsfilewriter.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used using namespace std; diff --git a/userspace/falco/utils.cpp b/userspace/falco/utils.cpp index af657a96..12900799 100644 --- a/userspace/falco/utils.cpp +++ b/userspace/falco/utils.cpp @@ -15,7 +15,7 @@ limitations under the License. */ #include "utils.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used void falco::utils::read(const std::string& filename, std::string& data) { diff --git a/userspace/falco/webserver.cpp b/userspace/falco/webserver.cpp index 1c0f2812..b1fe0e97 100644 --- a/userspace/falco/webserver.cpp +++ b/userspace/falco/webserver.cpp @@ -20,7 +20,7 @@ limitations under the License. #include "falco_common.h" #include "webserver.h" #include "json_evt.h" -#include "banned.h" +#include "banned.h" // This raises a compilation error when certain functions are used using json = nlohmann::json; using namespace std;