From 05dd170d707e4c4c9ab5ad2acdbd36c56f6b79d4 Mon Sep 17 00:00:00 2001 From: Leonardo Di Donato Date: Tue, 26 May 2020 17:52:34 +0000 Subject: [PATCH] fix(userspace/falco): virtual destructor of base grpc context Signed-off-by: Leonardo Di Donato --- userspace/falco/grpc_request_context.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/userspace/falco/grpc_request_context.h b/userspace/falco/grpc_request_context.h index 8a0174e4..4a9ec3e3 100644 --- a/userspace/falco/grpc_request_context.h +++ b/userspace/falco/grpc_request_context.h @@ -29,7 +29,8 @@ class request_context_base { public: request_context_base() = default; - ~request_context_base() = default; + // virtual to guarantee that the derived classes are destructed properly + virtual ~request_context_base() = default; std::unique_ptr<::grpc::ServerContext> m_srv_ctx; enum : char @@ -39,6 +40,7 @@ public: WRITE, FINISH } m_state = UNKNOWN; + virtual void start(server* srv) = 0; virtual void process(server* srv) = 0; virtual void end(server* srv, bool isError) = 0;