chore(userspace/falco): fix spacing and license

Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>

userspace/falco/CMakeLists.txt

@@ -16,7 +16,6 @@ configure_file(config_falco.h.in config_falco.h)
 set(
   FALCO_SOURCES
   app/app.cpp
-  app/state.cpp
   app/signals.cpp
   app/options.cpp
   app/actions/helpers_generic.cpp

userspace/falco/app/actions/compute_syscall_buffer_size.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/create_requested_paths.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -29,28 +29,7 @@ limitations under the License.
 using namespace falco::app;
 using namespace falco::app::actions;
 
-static int create_dir(const std::string &path)
+static int create_dir(const std::string &path);
-{
-	// Properly reset errno
-	errno = 0;
-
-	std::istringstream f(path);
-	std::string path_until_token;
-	std::string s;
-	// Create all the subfolder stopping at last token (f.eof());
-	// Examples:
-	// "/tmp/foo/bar" -> "", "tmp", "foo" -> mkdir("/") + mkdir("/tmp/") + midir("/tmp/foo/")
-	// "tmp/foo/bar" -> "tmp", "foo" -> mkdir("tmp/") + midir("tmp/foo/")
-	while (getline(f, s, *CPPPATH_SEP) && !f.eof()) {
-		path_until_token += s + CPPPATH_SEP;
-		int ret = mkdir(path_until_token.c_str(), 0600);
-		if (ret != 0 && errno != EEXIST)
-		{
-			return ret;
-		}
-	}
-	return 0;
-}
 
 falco::app::run_result falco::app::actions::create_requested_paths(falco::app::state& s)
 {
@@ -111,3 +90,25 @@ falco::app::run_result falco::app::actions::create_requested_paths(falco::app::s
 	return run_result::ok();
 }
 
+static int create_dir(const std::string &path)
+{
+	// Properly reset errno
+	errno = 0;
+
+	std::istringstream f(path);
+	std::string path_until_token;
+	std::string s;
+	// Create all the subfolder stopping at last token (f.eof());
+	// Examples:
+	// "/tmp/foo/bar" -> "", "tmp", "foo" -> mkdir("/") + mkdir("/tmp/") + midir("/tmp/foo/")
+	// "tmp/foo/bar" -> "tmp", "foo" -> mkdir("tmp/") + midir("tmp/foo/")
+	while (getline(f, s, *CPPPATH_SEP) && !f.eof()) {
+		path_until_token += s + CPPPATH_SEP;
+		int ret = mkdir(path_until_token.c_str(), 0600);
+		if (ret != 0 && errno != EEXIST)
+		{
+			return ret;
+		}
+	}
+	return 0;
+}

userspace/falco/app/actions/create_signal_handlers.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/daemonize.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/helpers_inspector.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/helpers_interesting_sets.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/init_clients.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/init_falco_engine.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/init_inspectors.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/init_outputs.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/list_fields.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/list_plugins.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/load_config.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/load_plugins.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/load_rules_files.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/print_generated_gvisor_config.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/print_ignored_events.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/print_page_size.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/print_plugin_info.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/print_support.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/print_syscall_events.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/print_version.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/process_events.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/actions/select_event_sources.cpp

@@ -1,9 +1,12 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
+
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
 You may obtain a copy of the License at
+
     http://www.apache.org/licenses/LICENSE-2.0
+
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

userspace/falco/app/actions/start_grpc_server.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -60,4 +60,3 @@ falco::app::run_result falco::app::actions::stop_grpc_server(falco::app::state&
 	return run_result::ok();
 }
 
-#endif

userspace/falco/app/actions/start_webserver.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -58,4 +58,3 @@ falco::app::run_result falco::app::actions::stop_webserver(falco::app::state& s)
 	return run_result::ok();
 }
 
-#endif

userspace/falco/app/actions/validate_rules_files.cpp

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.

userspace/falco/app/options.h

@@ -1,5 +1,5 @@
 /*
-Copyright (C) 2022 The Falco Authors.
+Copyright (C) 2023 The Falco Authors.
 
 Licensed under the Apache License, Version 2.0 (the "License");
 you may not use this file except in compliance with the License.
@@ -30,11 +30,11 @@ namespace app {
 class options {
 public:
 	options();
-    virtual ~options();
+	virtual ~options();
-    options(options&&) = default;
+	options(options&&) = default;
-    options& operator = (options&&) = default;
+	options& operator = (options&&) = default;
-    options(const options&) = default;
+	options(const options&) = default;
-    options& operator = (const options&) = default;
+	options& operator = (const options&) = default;
 
 	// Each of these maps directly to a command line option.
 	bool help;

userspace/falco/app/signals.cpp

@@ -22,7 +22,6 @@ std::atomic<int> falco::app::g_terminate(APP_SIGNAL_NOT_SET);
 std::atomic<int> falco::app::g_restart(APP_SIGNAL_NOT_SET);
 std::atomic<int> falco::app::g_reopen_outputs(APP_SIGNAL_NOT_SET);
 
-
 static inline bool should_take_action_to_signal(std::atomic<int>& v)
 {
 	// we expected the signal to be received, and we try to set action-taken flag

userspace/falco/app/signals.h

@@ -41,10 +41,12 @@ inline bool should_terminate()
 {
     return g_terminate.load(std::memory_order_seq_cst) != APP_SIGNAL_NOT_SET;
 }
+
 inline bool should_restart()
 {
     return g_restart.load(std::memory_order_seq_cst) != APP_SIGNAL_NOT_SET;
 }
+
 inline bool should_reopen_outputs()
 {
     return g_reopen_outputs.load(std::memory_order_seq_cst) != APP_SIGNAL_NOT_SET;

userspace/falco/app/state.cpp

@@ -1,32 +0,0 @@
-/*
-Copyright (C) 2023 The Falco Authors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
-    http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS,
-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-See the License for the specific language governing permissions and
-limitations under the License.
-*/
-
-#include "state.h"
-
-falco::app::state::state()
-	: loaded_sources(),
-	  enabled_sources(),
-	  source_infos(),
-	  plugin_configs(),
-	  ppm_sc_of_interest(),
-	  tp_of_interest(),
-	  syscall_buffer_bytes_size(DEFAULT_DRIVER_BUFFER_BYTES_DIM)
-{
-	config = std::make_shared<falco_configuration>();
-	engine = std::make_shared<falco_engine>();
-	offline_inspector = std::make_shared<sinsp>();
-	outputs = nullptr;
-}

userspace/falco/app/state.h

@@ -58,7 +58,20 @@ struct state
         std::shared_ptr<sinsp> inspector;
     };
 
-    state();
+    state():
+        loaded_sources(),
+        enabled_sources(),
+        source_infos(),
+        plugin_configs(),
+        ppm_sc_of_interest(),
+        tp_of_interest(),
+        syscall_buffer_bytes_size(DEFAULT_DRIVER_BUFFER_BYTES_DIM)
+    {
+        config = std::make_shared<falco_configuration>();
+        engine = std::make_shared<falco_engine>();
+        offline_inspector = std::make_shared<sinsp>();
+        outputs = nullptr;
+    }
     ~state() = default;
     state(state&&) = default;
     state& operator = (state&&) = default;
@@ -112,14 +125,14 @@ struct state
 #endif
 
     inline bool is_capture_mode() const 
-	{
+    {
-		return !options.trace_filename.empty();
+        return !options.trace_filename.empty();
-	}
+    }
 
-	inline bool is_gvisor_enabled() const
+    inline bool is_gvisor_enabled() const
-	{
+    {
-		return !options.gvisor_config.empty();
+        return !options.gvisor_config.empty();
-	}
+    }
 };
 
 }; // namespace app