github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-08-01 14:37:49 +00:00
Code Issues Projects Releases Wiki Activity

Make token bucket unit test pass valgrind

Browse Source 
Previously, valgrind was complaining about the leaked token bucket.

Signed-off-by: Mark Stemm <mark.stemm@gmail.com>
This commit is contained in:
Mark Stemm 2020-05-04 17:40:42 -07:00 committed by poiana
parent 7fd350d49a
commit 176d6f2bfe
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/engine/test_token_bucket.cpp
View File

@ -14,6 +14,8 @@ See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
#include <memory>
#include "token_bucket.h" #include "token_bucket.h"
#include <catch.hpp> #include <catch.hpp>
@ -21,7 +23,7 @@ using namespace Catch::literals;
TEST_CASE("token bucket default ctor", "[token_bucket]") TEST_CASE("token bucket default ctor", "[token_bucket]")
{ {
auto tb = new token_bucket(); auto tb = std::make_shared<token_bucket>();
REQUIRE(tb->get_tokens() == 1); REQUIRE(tb->get_tokens() == 1);
@ -38,7 +40,7 @@ TEST_CASE("token bucket default ctor", "[token_bucket]")
TEST_CASE("token bucket ctor with custom timer", "[token_bucket]") TEST_CASE("token bucket ctor with custom timer", "[token_bucket]")
{ {
auto t = []() -> uint64_t { return 22; }; auto t = []() -> uint64_t { return 22; };
auto tb = new token_bucket(t); auto tb = std::make_shared<token_bucket>(t);
REQUIRE(tb->get_tokens() == 1); REQUIRE(tb->get_tokens() == 1);
REQUIRE(tb->get_last_seen() == 22); REQUIRE(tb->get_last_seen() == 22);
@ -46,7 +48,7 @@ TEST_CASE("token bucket ctor with custom timer", "[token_bucket]")
TEST_CASE("token bucket with 2 tokens/sec rate, max 10 tokens", "[token_bucket]") TEST_CASE("token bucket with 2 tokens/sec rate, max 10 tokens", "[token_bucket]")
{ {
auto tb = new token_bucket(); auto tb = std::make_shared<token_bucket>();
tb->init(2.0, 10, 1); tb->init(2.0, 10, 1);
SECTION("claiming 5 tokens") SECTION("claiming 5 tokens")