diff --git a/userspace/falco/app_actions/init_clients.cpp b/userspace/falco/app_actions/init_clients.cpp index 776f3a58..fb94b698 100644 --- a/userspace/falco/app_actions/init_clients.cpp +++ b/userspace/falco/app_actions/init_clients.cpp @@ -21,7 +21,7 @@ using namespace falco::app; application::run_result application::init_clients() { #ifndef MINIMAL_BUILD - // k8s and mesos clients are useful only if syscall source is enabled + // k8s is useful only if the syscall source is enabled if (m_state->enabled_sources.find(falco_common::syscall_source) == m_state->enabled_sources.end()) { return run_result::ok(); @@ -59,7 +59,9 @@ application::run_result application::init_clients() } // + // DEPRECATED! // Run mesos, if required + // todo(leogr): remove in Falco 0,.35 // if(!m_options.mesos_api.empty()) { @@ -67,10 +69,12 @@ application::run_result application::init_clients() // passes a pointer but the inspector does // *not* own it and does not use it after // init_mesos_client() returns. + falco_logger::log(LOG_WARNING, "Mesos support has been DEPRECATED and will be removed in the next version!\n"); inspector->init_mesos_client(&(m_options.mesos_api), m_options.verbose); } else if(char* mesos_api_env = getenv("FALCO_MESOS_API")) { + falco_logger::log(LOG_WARNING, "Mesos support has been DEPRECATED and will be removed in the next version!\n"); std::string mesos_api_copy = mesos_api_env; inspector->init_mesos_client(&mesos_api_copy, m_options.verbose); } diff --git a/userspace/falco/app_cmdline_options.cpp b/userspace/falco/app_cmdline_options.cpp index 9bdcc5f7..0483ee62 100644 --- a/userspace/falco/app_cmdline_options.cpp +++ b/userspace/falco/app_cmdline_options.cpp @@ -190,14 +190,14 @@ void cmdline_options::define() ("list-plugins", "Print info on all loaded plugins and exit.", cxxopts::value(list_plugins)->default_value("false")) #endif #ifndef MINIMAL_BUILD - ("m,mesos-api", "Enable Mesos support by connecting to the API server specified as argument. E.g. \"http://admin:password@127.0.0.1:5050\". Marathon url is optional and defaults to Mesos address, port 8080. The API servers can also be specified via the environment variable FALCO_MESOS_API.", cxxopts::value(mesos_api), "") + ("m,mesos-api", "This feature has been DEPRECATED and will be removed in the next version.", cxxopts::value(mesos_api), "") #endif ("M", "Stop collecting after reached.", cxxopts::value(duration_to_tot)->default_value("0"), "") ("markdown", "When used with --list/--list-syscall-events, print the content in Markdown format", cxxopts::value(markdown)) ("N", "When used with --list, only print field names.", cxxopts::value(names_only)->default_value("false")) ("o,option", "Set the value of option to . Overrides values in configuration file. can be identified using its location in configuration file using dot notation. Elements which are entries of lists can be accessed via square brackets [].\n E.g. base.id = val\n base.subvalue.subvalue2 = val\n base.list[1]=val", cxxopts::value(cmdline_config_options), "=") ("plugin-info", "Print info for a single plugin and exit.\nThis includes all descriptivo info like name and author, along with the\nschema format for the init configuration and a list of suggested open parameters.\n can be the name of the plugin or its configured library_path.", cxxopts::value(print_plugin_info), "") - ("p,print", "Add additional information to each falco notification's output.\nWith -pc or -pcontainer will use a container-friendly format.\nWith -pk or -pkubernetes will use a kubernetes-friendly format.\nWith -pm or -pmesos will use a mesos-friendly format.\nAdditionally, specifying -pc/-pk/-pm will change the interpretation of %container.info in rule output fields.", cxxopts::value(print_additional), "") + ("p,print", "Add additional information to each falco notification's output.\nWith -pc or -pcontainer will use a container-friendly format.\nWith -pk or -pkubernetes will use a kubernetes-friendly format.\nAdditionally, specifying -pc/-pk will change the interpretation of %container.info in rule output fields.", cxxopts::value(print_additional), "") ("P,pidfile", "When run as a daemon, write pid to specified file", cxxopts::value(pidfilename)->default_value("/var/run/falco.pid"), "") ("r", "Rules file/directory (defaults to value set in configuration file, or /etc/falco_rules.yaml). This option can be passed multiple times to read from multiple files/directories.", cxxopts::value>(), "") ("s", "If specified, append statistics related to Falco's reading/processing of events to this file (only useful in live mode).", cxxopts::value(stats_filename), "")