diff --git a/userspace/engine/evttype_index_ruleset.cpp b/userspace/engine/evttype_index_ruleset.cpp index 33e04943..3af2ae32 100644 --- a/userspace/engine/evttype_index_ruleset.cpp +++ b/userspace/engine/evttype_index_ruleset.cpp @@ -56,7 +56,7 @@ bool evttype_index_ruleset::run_wrappers(sinsp_evt *evt, filter_wrapper_list &wrappers, uint16_t ruleset_id, falco_rule &match) { - for(auto &wrap : wrappers) { + for(const auto &wrap : wrappers) { if(wrap->m_filter->run(evt)) { match = wrap->m_rule; return true; @@ -72,7 +72,7 @@ bool evttype_index_ruleset::run_wrappers(sinsp_evt *evt, std::vector &matches) { bool match_found = false; - for(auto &wrap : wrappers) { + for(const auto &wrap : wrappers) { if(wrap->m_filter->run(evt)) { matches.push_back(wrap->m_rule); match_found = true; diff --git a/userspace/engine/rule_loader.cpp b/userspace/engine/rule_loader.cpp index d0b80048..5342da25 100644 --- a/userspace/engine/rule_loader.cpp +++ b/userspace/engine/rule_loader.cpp @@ -329,7 +329,7 @@ const std::string& rule_loader::result::as_summary_string() { os << " " << schema_validation_status.size() << " schema warnings: ["; bool first = true; - for(auto& status : schema_validation_status) { + for(const auto& status : schema_validation_status) { if(!first) { os << " "; } @@ -409,7 +409,7 @@ const std::string& rule_loader::result::as_verbose_string(const rules_contents_t os << schema_validation_status.size() << " Schema warnings:" << std::endl; - for(auto& status : schema_validation_status) { + for(const auto& status : schema_validation_status) { os << "------" << std::endl; os << status << std::endl; } diff --git a/userspace/engine/rule_loader_compiler.cpp b/userspace/engine/rule_loader_compiler.cpp index 49f07d1e..3d1ee9e5 100644 --- a/userspace/engine/rule_loader_compiler.cpp +++ b/userspace/engine/rule_loader_compiler.cpp @@ -271,7 +271,7 @@ static std::shared_ptr parse_condition(std::string condition, } } -void rule_loader::compiler::compile_list_infos(configuration& cfg, +void rule_loader::compiler::compile_list_infos(const configuration& cfg, const collector& col, indexed_vector& out) const { std::list used_names; @@ -300,7 +300,7 @@ void rule_loader::compiler::compile_list_infos(configuration& cfg, } // note: there is a visibility ordering between macros -void rule_loader::compiler::compile_macros_infos(configuration& cfg, +void rule_loader::compiler::compile_macros_infos(const configuration& cfg, const collector& col, indexed_vector& lists, indexed_vector& out) const { @@ -332,7 +332,7 @@ static bool err_is_unknown_type_or_field(const std::string& err) { err.find("unknown event type") != std::string::npos; } -bool rule_loader::compiler::compile_condition(configuration& cfg, +bool rule_loader::compiler::compile_condition(const configuration& cfg, filter_macro_resolver& macro_resolver, indexed_vector& lists, const indexed_vector& macros, @@ -389,7 +389,7 @@ bool rule_loader::compiler::compile_condition(configuration& cfg, return true; } -void rule_loader::compiler::compile_rule_infos(configuration& cfg, +void rule_loader::compiler::compile_rule_infos(const configuration& cfg, const collector& col, indexed_vector& lists, indexed_vector& macros, diff --git a/userspace/engine/rule_loader_compiler.h b/userspace/engine/rule_loader_compiler.h index 830eeda4..7bf7416b 100644 --- a/userspace/engine/rule_loader_compiler.h +++ b/userspace/engine/rule_loader_compiler.h @@ -56,7 +56,7 @@ protected: ast_out/filter_out with the compiled filter + ast. Returns false if the condition could not be compiled and should be skipped. */ - bool compile_condition(configuration& cfg, + bool compile_condition(const configuration& cfg, filter_macro_resolver& macro_resolver, indexed_vector& lists, const indexed_vector& macros, @@ -70,16 +70,16 @@ protected: std::shared_ptr& filter_out) const; private: - void compile_list_infos(configuration& cfg, + void compile_list_infos(const configuration& cfg, const collector& col, indexed_vector& out) const; - void compile_macros_infos(configuration& cfg, + void compile_macros_infos(const configuration& cfg, const collector& col, indexed_vector& lists, indexed_vector& out) const; - void compile_rule_infos(configuration& cfg, + void compile_rule_infos(const configuration& cfg, const collector& col, indexed_vector& lists, indexed_vector& macros, diff --git a/userspace/engine/rule_loader_reader.cpp b/userspace/engine/rule_loader_reader.cpp index 82c00139..f1ef075d 100644 --- a/userspace/engine/rule_loader_reader.cpp +++ b/userspace/engine/rule_loader_reader.cpp @@ -356,7 +356,7 @@ static void read_rule_exceptions(rule_loader::configuration& cfg, v_ex.name = name; // Check if an exception with the same name has already been defined - for(auto& exception : exceptions) { + for(const auto& exception : exceptions) { if(v_ex.name == exception.name) { cfg.res->add_warning( falco::load_result::LOAD_EXCEPTION_NAME_NOT_UNIQUE,