diff --git a/falco.yaml b/falco.yaml index 601f528d..8c71bc3c 100644 --- a/falco.yaml +++ b/falco.yaml @@ -290,8 +290,8 @@ rules_file: # BUFFERs 0 0 0 0 0 0 0 # # Moreover, you have the option to combine this parameter with -# `syscall_buf_size_preset` index. For instance, you can create a large shared -# syscall buffer of 512 MB (using syscall_buf_size_preset=10) that is +# `buf_size_preset` index. For instance, you can create a large shared +# syscall buffer of 512 MB (using buf_size_preset=10) that is # allocated among all the online CPUs. # # --- [Suggestions] @@ -302,7 +302,7 @@ rules_file: # the flexibility to experiment and find the optimal configuration for your # system. # -# When considering a fixed syscall_buf_size_preset and a fixed buffer dimension: +# When considering a fixed buf_size_preset and a fixed buffer dimension: # - Increasing this configs value results in lower number of buffers and you can # speed up your system and reduce memory usage # - However, using too few buffers may increase contention in the kernel, diff --git a/userspace/falco/app/actions/configure_syscall_buffer_size.cpp b/userspace/falco/app/actions/configure_syscall_buffer_size.cpp index 7e6c2a82..ca1cdae7 100644 --- a/userspace/falco/app/actions/configure_syscall_buffer_size.cpp +++ b/userspace/falco/app/actions/configure_syscall_buffer_size.cpp @@ -36,7 +36,7 @@ falco::app::run_result falco::app::actions::configure_syscall_buffer_size(falco: } if(index < MIN_INDEX || index > MAX_INDEX) { - return run_result::fatal("The 'syscall_buf_size_preset' value must be between '" + std::to_string(MIN_INDEX) + "' and '" + std::to_string(MAX_INDEX) + "'\n"); + return run_result::fatal("The 'buf_size_preset' value must be between '" + std::to_string(MIN_INDEX) + "' and '" + std::to_string(MAX_INDEX) + "'\n"); } /* Sizes from `1 MB` to `512 MB`. The index `0` is reserved, users cannot use it! */ @@ -56,13 +56,13 @@ falco::app::run_result falco::app::actions::configure_syscall_buffer_size(falco: /* Check if the chosen size is a multiple of the page size. */ if(chosen_size % page_size != 0) { - return run_result::fatal("The chosen syscall buffer size '" + std::to_string(chosen_size) + "' is not a multiple of your system page size '" + std::to_string(page_size) + "'. Please configure a greater 'syscall_buf_size_preset' value in the Falco configuration file\n"); + return run_result::fatal("The chosen syscall buffer size '" + std::to_string(chosen_size) + "' is not a multiple of your system page size '" + std::to_string(page_size) + "'. Please configure a greater 'buf_size_preset' value in the Falco configuration file\n"); } /* Check if the chosen size is greater than `2 * page_size`. */ if((chosen_size / page_size) <= 2) { - return run_result::fatal("The chosen syscall buffer size '" + std::to_string(chosen_size) + "' is not greater than '2 * " + std::to_string(page_size) + "' where '" + std::to_string(page_size) + "' is your system page size. Please configure a greater 'syscall_buf_size_preset' value in the Falco configuration file\n"); + return run_result::fatal("The chosen syscall buffer size '" + std::to_string(chosen_size) + "' is not greater than '2 * " + std::to_string(page_size) + "' where '" + std::to_string(page_size) + "' is your system page size. Please configure a greater 'buf_size_preset' value in the Falco configuration file\n"); } s.syscall_buffer_bytes_size = chosen_size;