github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-09-17 23:37:51 +00:00
Code Issues Projects Releases Wiki Activity

chore(userspace/falco): handle freeing of output objects

Browse Source 
Signed-off-by: Leonardo Grasso <me@leonardograsso.com>
This commit is contained in:
Leonardo Grasso
2020-11-18 12:14:47 +01:00
committed by poiana
parent a9dac551b8
commit 44955004e3
2 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
userspace/falco/falco_outputs.cpp
View File

@@ -58,6 +58,10 @@ falco_outputs::~falco_outputs()
{
m_worker_thread.join();
}
for(auto it = m_outputs.cbegin(); it != m_outputs.cend(); ++it)
{
delete *it;
}
}
}
@@ -94,7 +98,10 @@ void falco_outputs::init(bool json_output,
m_initialized = true;
}
// todo(leogr): when the worker has started, adding an outputs is not thread-safe
// This function has to be called after init() since some configuration settings
// need to be passed to the output plugins. Then, although the worker has started,
// the worker is still on hold, waiting for a message.
// Thus it is still safe to call add_output() before any message has been enqueued.
void falco_outputs::add_output(falco::outputs::config oc)
{

2
userspace/falco/outputs.h
View File

@@ -60,6 +60,8 @@ struct message
class abstract_output
{
public:
virtual ~abstract_output() {}
void init(config oc, bool buffered, std::string hostname)
{
m_oc = oc;