From 531bc3eb5a6fb1d13ab2c7998238956b767eca7b Mon Sep 17 00:00:00 2001 From: Mark Stemm Date: Mon, 7 Mar 2022 13:08:56 -0800 Subject: [PATCH] Falco test changes (small output matches) for actions With the split of falco_init into application:: methods, including a notion of a success/error/proceed result, there is a more concrete line between runtime errors (e.g. things that throw exceptions) and errors returned by methods that run the application. Some of the plugins tests were expecting errors to be returned by exceptions (e.g. with a leading "Runtime error: and a trailing " Exiting."). Now, the errors are just returned directly in application::run(), so drop the leading and trailing bits in expected test outputs. Signed-off-by: Mark Stemm --- test/falco_tests_plugins.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/falco_tests_plugins.yaml b/test/falco_tests_plugins.yaml index 1a105f6e..4e08a617 100644 --- a/test/falco_tests_plugins.yaml +++ b/test/falco_tests_plugins.yaml @@ -54,21 +54,21 @@ trace_files: !mux multiple_source_plugins: exit_status: 1 - stderr_contains: "Runtime error: Can not load multiple source plugins. cloudtrail already loaded. Exiting." + stderr_contains: "Can not load multiple source plugins. cloudtrail already loaded." conf_file: BUILD_DIR/test/confs/plugins/multiple_source_plugins.yaml rules_file: - rules/plugins/cloudtrail_create_instances.yaml incompatible_extract_sources: exit_status: 1 - stderr_contains: "Runtime error: Extractor plugin not compatible with event source aws_cloudtrail. Exiting." + stderr_contains: "Extractor plugin not compatible with event source aws_cloudtrail." conf_file: BUILD_DIR/test/confs/plugins/incompatible_extract_sources.yaml rules_file: - rules/plugins/cloudtrail_create_instances.yaml overlap_extract_sources: exit_status: 1 - stderr_contains: "Runtime error: Extractor plugins have overlapping compatible event source test_source. Exiting." + stderr_contains: "Extractor plugins have overlapping compatible event source test_source." conf_file: BUILD_DIR/test/confs/plugins/overlap_extract_sources.yaml rules_file: - rules/plugins/cloudtrail_create_instances.yaml @@ -82,7 +82,7 @@ trace_files: !mux incompat_plugin_rules_version: exit_status: 1 - stderr_contains: "Runtime error: Plugin cloudtrail version .* not compatible with required plugin version 100000.0.0. Exiting." + stderr_contains: "Plugin cloudtrail version .* not compatible with required plugin version 100000.0.0." conf_file: BUILD_DIR/test/confs/plugins/cloudtrail_json_create_instances.yaml rules_file: - rules/plugins/cloudtrail_incompat_plugin_version.yaml