From 56de6e678657a7850992260b2ea6f6bb0b6db76e Mon Sep 17 00:00:00 2001 From: Andrea Terzolo Date: Tue, 9 Jan 2024 12:33:58 +0100 Subject: [PATCH] update(rule_loader): remove the warning on the required_engine_version Signed-off-by: Andrea Terzolo --- unit_tests/engine/test_rule_loader.cpp | 2 +- userspace/engine/rule_loader_reader.cpp | 1 - userspace/engine/rule_loader_reader.h | 3 --- 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/unit_tests/engine/test_rule_loader.cpp b/unit_tests/engine/test_rule_loader.cpp index e4c5d70f..1b11a2ae 100644 --- a/unit_tests/engine/test_rule_loader.cpp +++ b/unit_tests/engine/test_rule_loader.cpp @@ -583,7 +583,7 @@ TEST_F(engine_loader_test, required_engine_version_not_semver) )END"; ASSERT_TRUE(load_rules(rules_content, "rules.yaml")); - ASSERT_TRUE(check_warning_message(WARNING_ENGINE_VERSION_NOT_SEMVER)); + ASSERT_FALSE(has_warnings()); } TEST_F(engine_loader_test, required_engine_version_invalid) diff --git a/userspace/engine/rule_loader_reader.cpp b/userspace/engine/rule_loader_reader.cpp index 8258b13b..0b7e1a64 100644 --- a/userspace/engine/rule_loader_reader.cpp +++ b/userspace/engine/rule_loader_reader.cpp @@ -368,7 +368,6 @@ static void read_item( // Build proper semver representation v.version = rule_loader::reader::get_implicit_engine_version(ver); - cfg.res->add_warning(falco::load_result::LOAD_DEPRECATED_ITEM, WARNING_ENGINE_VERSION_NOT_SEMVER, ctx); } catch(std::exception& e) { diff --git a/userspace/engine/rule_loader_reader.h b/userspace/engine/rule_loader_reader.h index 768f7e4e..877f9d45 100644 --- a/userspace/engine/rule_loader_reader.h +++ b/userspace/engine/rule_loader_reader.h @@ -32,9 +32,6 @@ limitations under the License. // Warning message used when `enabled` is used without override. #define WARNING_ENABLED_MESSAGE "The standalone 'enabled' key usage is deprecated. The correct approach requires also a 'replace' entry under the 'override' key (i.e. 'enabled: replace')." -// Warning message used when the `required_engine_version` is not semver compatible. -#define WARNING_ENGINE_VERSION_NOT_SEMVER "The 'required_engine_version' should be SemVer compatible. All non-SemVer compatible values are deprecated." - namespace rule_loader {