From 572a1e838131d761cd2277754b0ce14802c384c0 Mon Sep 17 00:00:00 2001 From: Lorenzo Fontana Date: Thu, 5 Sep 2019 12:04:18 +0200 Subject: [PATCH] update(userspace/falco): keep the stream open Co-Authored-By: Leonardo Di Donato Signed-off-by: Lorenzo Fontana --- userspace/falco/grpc_server.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/userspace/falco/grpc_server.cpp b/userspace/falco/grpc_server.cpp index 8672dfbe..715ae56f 100644 --- a/userspace/falco/grpc_server.cpp +++ b/userspace/falco/grpc_server.cpp @@ -84,7 +84,7 @@ void request_stream_context::end(fa // Complete the processing falco_output_response res; - (srv->*m_process_func)(*m_stream_ctx, m_req, res); + (srv->*m_process_func)(*m_stream_ctx, m_req, res); // subscribe() } else { @@ -117,16 +117,15 @@ void falco_grpc_server_impl::subscribe(const stream_context& ctx, const falco_ou { // Start (or continue) streaming // ctx.m_status == stream_context::STREAMING - // todo > do we want batching? - + dequeue: if(!m_event_queue.try_pop(res)) { - // TODO: log that we've not been able to pop? + // TODO: backoff mechanism that does has more false + goto dequeue; } ctx.m_has_more = true; } - // todo > print/store statistics } void falco_grpc_server::thread_process(int thread_index)