From 62e762a467b8e4423f7a0d53e20804541315fd52 Mon Sep 17 00:00:00 2001 From: Andrea Terzolo Date: Fri, 1 Sep 2023 19:19:42 +0200 Subject: [PATCH] cleanup: deprecate no more supported `userspace` mode Signed-off-by: Andrea Terzolo --- userspace/falco/app/actions/helpers_inspector.cpp | 2 +- userspace/falco/app/options.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/userspace/falco/app/actions/helpers_inspector.cpp b/userspace/falco/app/actions/helpers_inspector.cpp index a927d9ee..f6515a2d 100644 --- a/userspace/falco/app/actions/helpers_inspector.cpp +++ b/userspace/falco/app/actions/helpers_inspector.cpp @@ -91,7 +91,7 @@ falco::app::run_result falco::app::actions::open_live_inspector( // // Falco uses a ptrace(2) based userspace implementation. // Regardless of the implementation, the underlying method remains the same. - falco_logger::log(LOG_INFO, "Opening '" + source + "' source with udig\n"); + falco_logger::log(LOG_WARNING, "The udig engine is deprecated and will be removed in Falco 0.37. Opening '" + source + "' source with udig\n"); inspector->open_udig(); } else if(s.is_gvisor_enabled()) /* gvisor engine. */ diff --git a/userspace/falco/app/options.cpp b/userspace/falco/app/options.cpp index 106021cb..562b2e45 100644 --- a/userspace/falco/app/options.cpp +++ b/userspace/falco/app/options.cpp @@ -220,7 +220,7 @@ void options::define(cxxopts::Options& opts) ("t", "Only run those rules with a tag=. This option can be passed multiple times. Can not be mixed with -T/-D.", cxxopts::value>(), "") ("U,unbuffered", "Turn off output buffering to configured outputs. This causes every single line emitted by falco to be flushed which generates higher CPU usage but is useful when piping those outputs into another process or into a script.", cxxopts::value(unbuffered_outputs)->default_value("false")) #if !defined(_WIN32) && !defined(__EMSCRIPTEN__) && !defined(MINIMAL_BUILD) - ("u,userspace", "Parse events from userspace. To be used in conjunction with the ptrace(2) based driver (pdig)", cxxopts::value(userspace)->default_value("false")) + ("u,userspace", "[DEPRECATED, will be removed in Falco 0.37] Parse events from userspace. To be used in conjunction with the ptrace(2) based driver (pdig)", cxxopts::value(userspace)->default_value("false")) #endif ("V,validate", "Read the contents of the specified rules(s) file and exit. This option can be passed multiple times to validate multiple files.", cxxopts::value(validate_rules_filenames), "") ("v", "Verbose output.", cxxopts::value(verbose)->default_value("false"))