github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-09-05 08:40:52 +00:00
Code Issues Projects Releases Wiki Activity

fix(userspace): accessing a (json) object can throw exceptions because of wrong types

Browse Source 
Signed-off-by: Leonardo Di Donato <leodidonato@gmail.com>
This commit is contained in:
Leonardo Di Donato
2019-08-01 18:59:26 +00:00
committed by Lorenzo Fontana
parent 330d7ef2d7
commit 723bc1cabf
1 changed files with 32 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
userspace/engine/falco_engine.cpp
View File

@@ -365,7 +365,10 @@ unique_ptr<falco_engine::rule_result> falco_engine::process_k8s_audit_event(json
bool falco_engine::parse_k8s_audit_json(nlohmann::json &j, std::list<json_event> &evts) bool falco_engine::parse_k8s_audit_json(nlohmann::json &j, std::list<json_event> &evts)
{ {
// If the Kind is EventList, split it into individual events. // Note that nlohmann::basic_json::value can throw nlohmann::basic_json::type_error (302, 306)
try
{
// If the kind is EventList, split it into individual events
if(j.value("kind", "<NA>") == "EventList") if(j.value("kind", "<NA>") == "EventList")
{ {
for(auto &je : j["items"]) for(auto &je : j["items"])
@@ -396,7 +399,6 @@ bool falco_engine::parse_k8s_audit_json(nlohmann::json &j, std::list<json_event>
return false; return false;
} }
evts.back().set_jevt(j, ns); evts.back().set_jevt(j, ns);
return true; return true;
} }
@@ -404,7 +406,13 @@ bool falco_engine::parse_k8s_audit_json(nlohmann::json &j, std::list<json_event>
{ {
return false; return false;
} }
}
catch(exception &e)
{
// Propagate the exception
rethrow_exception(current_exception());
return false;
}
} }
unique_ptr<falco_engine::rule_result> falco_engine::process_k8s_audit_event(json_event *ev) unique_ptr<falco_engine::rule_result> falco_engine::process_k8s_audit_event(json_event *ev)