github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-08-09 10:07:57 +00:00
Code Issues Projects Releases Wiki Activity

update(userpace/engine): properly implement semver check for required plugin versions.

Browse Source 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
This commit is contained in:
Federico Di Pierro 2022-01-28 14:28:54 +01:00 committed by poiana
parent a4199814a0
commit 75c6cfb414
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
userspace/engine/falco_engine.cpp
View File

@ -432,7 +432,7 @@ bool falco_engine::is_plugin_compatible(const std::string &name,
const std::string &version, const std::string &version,
std::string &required_version) std::string &required_version)
{ {
sinsp_plugin::version plugin_version(version.c_str()); sinsp_plugin::version plugin_version(version);
if(!plugin_version.m_valid) if(!plugin_version.m_valid)
{ {
@ -447,13 +447,11 @@ bool falco_engine::is_plugin_compatible(const std::string &name,
for(auto &rversion : m_required_plugin_versions[name]) for(auto &rversion : m_required_plugin_versions[name])
{ {
sinsp_plugin::version req_version(rversion.c_str()); sinsp_plugin::version req_version(rversion);
if(req_version.m_version_major > plugin_version.m_version_major) if (!plugin_version.check(req_version))
{ {
required_version = rversion;
return false; return false;
} }
} }
return true; return true;