github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-09-23 10:57:59 +00:00
Code Issues Projects Releases Wiki Activity

fix(userspace/falco): solve warning

Browse Source 
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
This commit is contained in:
Jason Dellaluce
2022-10-10 11:53:37 +00:00
committed by poiana
parent e011b3b5e5
commit 77857a7236
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
userspace/falco/app_actions/create_signal_handlers.cpp
View File

@@ -75,7 +75,7 @@ application::run_result application::create_signal_handlers()
falco::app::g_terminate.store(APP_SIGNAL_NOT_SET, std::memory_order_seq_cst); falco::app::g_terminate.store(APP_SIGNAL_NOT_SET, std::memory_order_seq_cst);
falco::app::g_restart.store(APP_SIGNAL_NOT_SET, std::memory_order_seq_cst); falco::app::g_restart.store(APP_SIGNAL_NOT_SET, std::memory_order_seq_cst);
falco::app::g_reopen_outputs.store(APP_SIGNAL_NOT_SET, std::memory_order_seq_cst); falco::app::g_reopen_outputs.store(APP_SIGNAL_NOT_SET, std::memory_order_seq_cst);
if (!g_terminate.is_lock_free() if (!g_terminate.is_lock_free()
|| !g_restart.is_lock_free() || !g_restart.is_lock_free()
|| !g_reopen_outputs.is_lock_free()) || !g_reopen_outputs.is_lock_free())
@@ -83,12 +83,15 @@ application::run_result application::create_signal_handlers()
falco_logger::log(LOG_WARNING, "Bundled atomics implementation is not lock-free, signal handlers may be unstable\n"); falco_logger::log(LOG_WARNING, "Bundled atomics implementation is not lock-free, signal handlers may be unstable\n");
} }
// we use the if just to make sure we return at the first failed statement
run_result ret; run_result ret;
if(! create_handler(SIGINT, ::terminate_signal_handler, ret) || if(! create_handler(SIGINT, ::terminate_signal_handler, ret) ||
! create_handler(SIGTERM, ::terminate_signal_handler, ret) || ! create_handler(SIGTERM, ::terminate_signal_handler, ret) ||
! create_handler(SIGUSR1, ::reopen_outputs_signal_handler, ret) || ! create_handler(SIGUSR1, ::reopen_outputs_signal_handler, ret) ||
! create_handler(SIGHUP, ::restart_signal_handler, ret)); ! create_handler(SIGHUP, ::restart_signal_handler, ret))
{
// we use the if just to make sure we return at the first failed statement
}
return ret; return ret;
} }