github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-07-18 16:51:30 +00:00
Code Issues Projects Releases Wiki Activity

update(userspace): pass string as const refs when possible

Browse Source 
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
This commit is contained in:
Jason Dellaluce 2022-10-06 16:31:42 +00:00 committed by poiana
parent b4ea2f4da2
commit 83a83a5853
3 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
userspace/engine/filter_evttype_resolver.cpp
View File

@ -17,12 +17,11 @@ limitations under the License.
#include "filter_evttype_resolver.h" #include "filter_evttype_resolver.h"
#include <sinsp.h> #include <sinsp.h>
using namespace std;
using namespace libsinsp::filter; using namespace libsinsp::filter;
extern sinsp_evttables g_infotables; extern sinsp_evttables g_infotables;
static bool is_evttype_operator(const string& op) static bool is_evttype_operator(const std::string& op)
{ {
return op == "==" || op == "=" || op == "!=" || op == "in"; return op == "==" || op == "=" || op == "!=" || op == "in";
} }
@ -44,7 +43,7 @@ void filter_evttype_resolver::visitor::inversion(falco_event_types& types)
} }
} }
void filter_evttype_resolver::visitor::evttypes(string evtname, falco_event_types& out) void filter_evttype_resolver::visitor::evttypes(const std::string& evtname, falco_event_types& out)
{ {
// Fill in from 2 to PPM_EVENT_MAX-1. 0 and 1 are excluded as // Fill in from 2 to PPM_EVENT_MAX-1. 0 and 1 are excluded as
// those are PPM_GENERIC_E/PPME_GENERIC_X // those are PPM_GENERIC_E/PPME_GENERIC_X
@ -53,7 +52,7 @@ void filter_evttype_resolver::visitor::evttypes(string evtname, falco_event_type
{ {
// Skip unused events or events not matching the requested evtname // Skip unused events or events not matching the requested evtname
if(!(etable[i].flags & EF_UNUSED) if(!(etable[i].flags & EF_UNUSED)
&& (evtname.empty() || string(etable[i].name) == evtname)) && (evtname.empty() || std::string(etable[i].name) == evtname))
{ {
out.insert(i); out.insert(i);
} }

4
userspace/engine/filter_evttype_resolver.h
View File

@ -157,7 +157,7 @@ public:
string is passed, all the available evttypes are collected string is passed, all the available evttypes are collected
\param out The set to be filled with the evttypes \param out The set to be filled with the evttypes
*/ */
inline void evttypes(std::string evtname, falco_event_types& out) const inline void evttypes(const std::string& evtname, falco_event_types& out) const
{ {
falco_event_types evt_types; falco_event_types evt_types;
visitor().evttypes(evtname, evt_types); visitor().evttypes(evtname, evt_types);
@ -205,6 +205,6 @@ private:
void visit(libsinsp::filter::ast::unary_check_expr* e) override; void visit(libsinsp::filter::ast::unary_check_expr* e) override;
void visit(libsinsp::filter::ast::binary_check_expr* e) override; void visit(libsinsp::filter::ast::binary_check_expr* e) override;
void inversion(falco_event_types& types); void inversion(falco_event_types& types);
void evttypes(std::string evtname, falco_event_types& out); void evttypes(const std::string& evtname, falco_event_types& out);
}; };
}; };

2
userspace/falco/app_actions/print_support.cpp
View File

@ -21,7 +21,7 @@ limitations under the License.
using namespace falco::app; using namespace falco::app;
static std::string read_file(std::string &filename) static std::string read_file(const std::string &filename)
{ {
std::ifstream t(filename); std::ifstream t(filename);
std::string str((std::istreambuf_iterator<char>(t)), std::string str((std::istreambuf_iterator<char>(t)),