From 97207d309a1d95908c6b949d3cc18d14da3f206f Mon Sep 17 00:00:00 2001 From: Melissa Kilby Date: Sat, 1 Jun 2024 03:50:40 +0000 Subject: [PATCH] fix(metrics): allow each metric output channel to be selected independently Signed-off-by: Melissa Kilby --- userspace/falco/app/actions/process_events.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/userspace/falco/app/actions/process_events.cpp b/userspace/falco/app/actions/process_events.cpp index 6f3dfa4f..2f14c1bf 100644 --- a/userspace/falco/app/actions/process_events.cpp +++ b/userspace/falco/app/actions/process_events.cpp @@ -413,9 +413,9 @@ static falco::app::run_result init_stats_writer( return falco::app::run_result::fatal("Metrics interval was passed as numeric value without Prometheus time unit. Please specify a time unit"); } - if (config->m_metrics_enabled && !sw->has_output()) + if (config->m_metrics_enabled && !(sw->has_output() || config->m_webserver_config.m_prometheus_metrics_enabled)) { - return falco::app::run_result::fatal("Metrics are enabled with no output configured. Please enable at least one output channel"); + return falco::app::run_result::fatal("Metrics are enabled with no output configured. Please enable at least one output channel ('metrics.output_rule', 'metrics.output_file' or 'webserver.prometheus_metrics_enabled')"); } falco_logger::log(falco_logger::level::INFO, "Setting metrics interval to " + config->m_metrics_interval_str + ", equivalent to " + std::to_string(config->m_metrics_interval) + " (ms)\n");