From 9a175cb1dbcc59831898afeec7463132974b17df Mon Sep 17 00:00:00 2001 From: Angelo Puglisi Date: Tue, 24 Nov 2020 18:32:56 +0100 Subject: [PATCH] chore(cmake/modules): avoid useless rebuild Because of https://gitlab.kitware.com/cmake/cmake/-/issues/16419, every time one compiles, some external projects gets updated causing rebuild. Have EP_UPDATE_DISCONNECTED option (default OFF) to be able to control that behaviour. Signed-off-by: Angelo Puglisi Co-authored-by: Leonardo Di Donato Signed-off-by: Leonardo Di Donato --- CMakeLists.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index e873e8e9..8efa759f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -19,6 +19,15 @@ option(BUILD_WARNINGS_AS_ERRORS "Enable building with -Wextra -Werror flags" OFF option(MINIMAL_BUILD "Build a minimal version of Falco, containing only the engine and basic input/output (EXPERIMENTAL)" OFF) option(MUSL_OPTIMIZED_BUILD "Enable if you want a musl optimized build" OFF) +# We shouldn't need to set this, see https://gitlab.kitware.com/cmake/cmake/-/issues/16419 +option(EP_UPDATE_DISCONNECTED "ExternalProject update disconnected" OFF) +if (${EP_UPDATE_DISCONNECTED}) + set_property( + DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} + PROPERTY EP_UPDATE_DISCONNECTED TRUE) +endif() + + # Elapsed time # set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE "${CMAKE_COMMAND} -E time") # TODO(fntlnz, leodido): add a flag to enable this