From 9c184af2a1a28a8cc3852ee26888434974662175 Mon Sep 17 00:00:00 2001 From: Jason Dellaluce Date: Thu, 1 Sep 2022 14:08:17 +0000 Subject: [PATCH] fix(userspace/falco): adopt stricter memory order semantics Signed-off-by: Jason Dellaluce --- userspace/falco/app_actions/process_events.cpp | 4 ++-- userspace/falco/application.cpp | 4 ++-- userspace/falco/webserver.cpp | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/userspace/falco/app_actions/process_events.cpp b/userspace/falco/app_actions/process_events.cpp index 8efe12fb..645a9f92 100644 --- a/userspace/falco/app_actions/process_events.cpp +++ b/userspace/falco/app_actions/process_events.cpp @@ -97,8 +97,8 @@ application::run_result application::do_inspect( { rc = inspector->next(&ev); - if(m_state->terminate.load(std::memory_order_acquire) - || m_state->restart.load(std::memory_order_acquire)) + if(m_state->terminate.load(std::memory_order_seq_cst) + || m_state->restart.load(std::memory_order_seq_cst)) { break; } diff --git a/userspace/falco/application.cpp b/userspace/falco/application.cpp index 8e0fa2db..7efe4409 100644 --- a/userspace/falco/application.cpp +++ b/userspace/falco/application.cpp @@ -69,7 +69,7 @@ void application::terminate() { if(m_state != nullptr) { - m_state->terminate.store(true, std::memory_order_release); + m_state->terminate.store(true, std::memory_order_seq_cst); } } @@ -87,7 +87,7 @@ void application::restart() { if(m_state != nullptr) { - m_state->restart.store(true, std::memory_order_release); + m_state->restart.store(true, std::memory_order_seq_cst); } } diff --git a/userspace/falco/webserver.cpp b/userspace/falco/webserver.cpp index c4567db9..fcd87e72 100644 --- a/userspace/falco/webserver.cpp +++ b/userspace/falco/webserver.cpp @@ -66,7 +66,7 @@ void falco_webserver::start( } std::atomic failed; - failed.store(false, std::memory_order_relaxed); + failed.store(false, std::memory_order_release); m_server_thread = std::thread([this, listen_port, &failed] { try