github/falco
1
0
Fork 0
mirror of https://github.com/falcosecurity/falco.git synced 2025-09-23 10:57:59 +00:00
Code Issues Projects Releases Wiki Activity

chore(userspace/falco): small cleanup.

Browse Source 
Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
This commit is contained in:
Federico Di Pierro
2022-05-06 10:38:40 +02:00
committed by poiana
parent e32f5a66c5
commit a9fe979071
1 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
userspace/falco/app_actions/create_signal_handlers.cpp
View File

@@ -93,12 +93,12 @@ application::run_result application::attach_inotify_signals()
run_result ret; run_result ret;
if (m_options.monitor_files) if (m_options.monitor_files)
{ {
ret.proceed = false;
ret.success = false;
inot_fd = inotify_init(); inot_fd = inotify_init();
if (inot_fd == -1) if (inot_fd == -1)
{ {
ret.success = false;
ret.errstr = std::string("Could not create inotify handler."); ret.errstr = std::string("Could not create inotify handler.");
ret.proceed = false;
return ret; return ret;
} }
@@ -108,18 +108,14 @@ application::run_result application::attach_inotify_signals()
sa.sa_handler = restart_falco; sa.sa_handler = restart_falco;
if (sigaction(SIGIO, &sa, NULL) == -1) if (sigaction(SIGIO, &sa, NULL) == -1)
{ {
ret.success = false;
ret.errstr = std::string("Failed to link SIGIO to inotify handler."); ret.errstr = std::string("Failed to link SIGIO to inotify handler.");
ret.proceed = false;
return ret; return ret;
} }
/* Set owner process that is to receive "I/O possible" signal */ /* Set owner process that is to receive "I/O possible" signal */
if (fcntl(inot_fd, F_SETOWN, getpid()) == -1) if (fcntl(inot_fd, F_SETOWN, getpid()) == -1)
{ {
ret.success = false;
ret.errstr = std::string("Failed to setting owner on inotify handler."); ret.errstr = std::string("Failed to setting owner on inotify handler.");
ret.proceed = false;
return ret; return ret;
} }
@@ -130,9 +126,7 @@ application::run_result application::attach_inotify_signals()
int flags = fcntl(inot_fd, F_GETFL); int flags = fcntl(inot_fd, F_GETFL);
if (fcntl(inot_fd, F_SETFL, flags | O_ASYNC | O_NONBLOCK) == -1) if (fcntl(inot_fd, F_SETFL, flags | O_ASYNC | O_NONBLOCK) == -1)
{ {
ret.success = false;
ret.errstr = std::string("Failed to setting flags on inotify handler."); ret.errstr = std::string("Failed to setting flags on inotify handler.");
ret.proceed = false;
return ret; return ret;
} }
@@ -140,9 +134,7 @@ application::run_result application::attach_inotify_signals()
int wd = inotify_add_watch(inot_fd, m_options.conf_filename.c_str(), IN_CLOSE_WRITE); int wd = inotify_add_watch(inot_fd, m_options.conf_filename.c_str(), IN_CLOSE_WRITE);
if (wd == -1) if (wd == -1)
{ {
ret.success = false;
ret.errstr = std::string("Failed to watch conf file."); ret.errstr = std::string("Failed to watch conf file.");
ret.proceed = false;
return ret; return ret;
} }
falco_logger::log(LOG_DEBUG, "Watching " + m_options.conf_filename +"\n"); falco_logger::log(LOG_DEBUG, "Watching " + m_options.conf_filename +"\n");
@@ -151,15 +143,14 @@ application::run_result application::attach_inotify_signals()
wd = inotify_add_watch(inot_fd, rule.c_str(), IN_CLOSE_WRITE); wd = inotify_add_watch(inot_fd, rule.c_str(), IN_CLOSE_WRITE);
if (wd == -1) if (wd == -1)
{ {
ret.success = false;
ret.errstr = std::string("Failed to watch rule file: ") + rule; ret.errstr = std::string("Failed to watch rule file: ") + rule;
ret.proceed = false;
return ret; return ret;
} }
falco_logger::log(LOG_DEBUG, "Watching " + rule +"\n"); falco_logger::log(LOG_DEBUG, "Watching " + rule +"\n");
} }
ret.success = true;
ret.proceed = true;
} }
return ret; return ret;
} }